admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary RtcEventLog parameter in RtpTransportControllerSend::CreateRtpVideoSender

Browse Source 
RtpTransportControllerSend has access to the same Environment as the caller, and thus can take RtcEventLog directly from it.

Bug: None
Change-Id: I4b20811d3f6de8193c63d6c58d0fe1204b3ec7b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342040
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41864}
This commit is contained in:
Danil Chapovalov 2024-03-06 16:30:34 +01:00 committed by WebRTC LUCI CQ
parent 5ace0710bf
commit ac2720e967
6 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
call/BUILD.gn
View File

@ -116,7 +116,6 @@ rtc_library("rtp_interfaces") {
"../api:rtp_parameters",
"../api/crypto:options",
"../api/environment",
"../api/rtc_event_log",
"../api/transport:bandwidth_estimation_settings",
"../api/transport:bitrate_settings",
"../api/transport:network_control",

5
call/rtp_transport_controller_send.cc
View File

@ -128,7 +128,6 @@ RtpVideoSenderInterface* RtpTransportControllerSend::CreateRtpVideoSender(
int rtcp_report_interval_ms,
Transport* send_transport,
const RtpSenderObservers& observers,
RtcEventLog* event_log,
std::unique_ptr<FecController> fec_controller,
const RtpSenderFrameEncryptionConfig& frame_encryption_config,
rtc::scoped_refptr<FrameTransformerInterface> frame_transformer) {
@ -138,8 +137,8 @@ RtpVideoSenderInterface* RtpTransportControllerSend::CreateRtpVideoSender(
rtcp_report_interval_ms, send_transport, observers,
// TODO(holmer): Remove this circular dependency by injecting
// the parts of RtpTransportControllerSendInterface that are really used.
this, event_log, &retransmission_rate_limiter_, std::move(fec_controller),
frame_encryption_config.frame_encryptor,
this, &env_.event_log(), &retransmission_rate_limiter_,
std::move(fec_controller), frame_encryption_config.frame_encryptor,
frame_encryption_config.crypto_options, std::move(frame_transformer),
env_.field_trials(), &env_.task_queue_factory()));
return video_rtp_senders_.back().get();

2
call/rtp_transport_controller_send.h
View File

@ -42,7 +42,6 @@
namespace webrtc {
class FrameEncryptorInterface;
class RtcEventLog;
class RtpTransportControllerSend final
: public RtpTransportControllerSendInterface,
@ -66,7 +65,6 @@ class RtpTransportControllerSend final
int rtcp_report_interval_ms,
Transport* send_transport,
const RtpSenderObservers& observers,
RtcEventLog* event_log,
std::unique_ptr<FecController> fec_controller,
const RtpSenderFrameEncryptionConfig& frame_encryption_config,
rtc::scoped_refptr<FrameTransformerInterface> frame_transformer) override;

2
call/rtp_transport_controller_send_interface.h
View File

@ -23,7 +23,6 @@
#include "api/crypto/crypto_options.h"
#include "api/fec_controller.h"
#include "api/frame_transformer_interface.h"
#include "api/rtc_event_log/rtc_event_log.h"
#include "api/transport/bandwidth_estimation_settings.h"
#include "api/transport/bitrate_settings.h"
#include "api/units/timestamp.h"
@ -102,7 +101,6 @@ class RtpTransportControllerSendInterface {
int rtcp_report_interval_ms,
Transport* send_transport,
const RtpSenderObservers& observers,
RtcEventLog* event_log,
std::unique_ptr<FecController> fec_controller,
const RtpSenderFrameEncryptionConfig& frame_encryption_config,
rtc::scoped_refptr<FrameTransformerInterface> frame_transformer) = 0;

1
call/test/mock_rtp_transport_controller_send.h
View File

@ -41,7 +41,6 @@ class MockRtpTransportControllerSend
int rtcp_report_interval_ms,
Transport*,
const RtpSenderObservers&,
RtcEventLog*,
std::unique_ptr<FecController>,
const RtpSenderFrameEncryptionConfig&,
rtc::scoped_refptr<FrameTransformerInterface>),

1
video/video_send_stream_impl.cc
View File

@ -437,7 +437,6 @@ VideoSendStreamImpl::VideoSendStreamImpl(
&encoder_feedback_,
&stats_proxy_,
&send_packet_observer_),
&env_.event_log(),
std::move(fec_controller),
CreateFrameEncryptionConfig(&config_),
config_.frame_transformer)),