From ab89d02b050c613261596f0cfb309bab93b93207 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Fri, 2 Oct 2020 16:04:46 +0200 Subject: [PATCH] Cleans up code related to early loss detection flag. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:10676 Change-Id: I32dab4d4cfc4e8e09c3611b1484fb4394b7efbad Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186563 Reviewed-by: Sebastian Jansson Commit-Queue: Erik Språng Cr-Commit-Position: refs/heads/master@{#32295} --- call/rtp_video_sender.cc | 5 ----- call/rtp_video_sender.h | 1 - 2 files changed, 6 deletions(-) diff --git a/call/rtp_video_sender.cc b/call/rtp_video_sender.cc index caee744e76..aa53ff89a3 100644 --- a/call/rtp_video_sender.cc +++ b/call/rtp_video_sender.cc @@ -337,9 +337,6 @@ RtpVideoSender::RtpVideoSender( account_for_packetization_overhead_(!absl::StartsWith( field_trials_.Lookup("WebRTC-SubtractPacketizationOverhead"), "Disabled")), - use_early_loss_detection_(!absl::StartsWith( - field_trials_.Lookup("WebRTC-UseEarlyLossDetection"), - "Disabled")), has_packet_feedback_(TransportSeqNumExtensionConfigured(rtp_config)), use_deferred_fec_(!absl::StartsWith( field_trials_.Lookup("WebRTC-DeferredFecGeneration"), @@ -899,7 +896,6 @@ void RtpVideoSender::OnPacketFeedbackVector( } } - if (use_early_loss_detection_) { // Map from SSRC to vector of RTP sequence numbers that are indicated as // lost by feedback, without being trailed by any received packets. std::map> early_loss_detected_per_ssrc; @@ -925,7 +921,6 @@ void RtpVideoSender::OnPacketFeedbackVector( rtp_sender->ReSendPacket(sequence_number); } } - } for (const auto& kv : acked_packets_per_ssrc) { const uint32_t ssrc = kv.first; diff --git a/call/rtp_video_sender.h b/call/rtp_video_sender.h index 9ec10c4606..33dd5b744a 100644 --- a/call/rtp_video_sender.h +++ b/call/rtp_video_sender.h @@ -172,7 +172,6 @@ class RtpVideoSender : public RtpVideoSenderInterface, const FieldTrialBasedConfig field_trials_; const bool send_side_bwe_with_overhead_; const bool account_for_packetization_overhead_; - const bool use_early_loss_detection_; const bool has_packet_feedback_; const bool use_deferred_fec_;