From ab86e7ffe2106c086cde631eee1418f2c128b05b Mon Sep 17 00:00:00 2001 From: Taylor Brandstetter Date: Mon, 12 Feb 2018 15:16:02 -0800 Subject: [PATCH] Disable a couple flaky RampUpTest tests on Mac. Specifically, UpDownUpAudioVideoTransportSequenceNumberRtx and AudioTransportSequenceNumber. TBR=stefan@webrtc.org Bug: webrtc:8878 Change-Id: I24ad65dc56068bb01c53d97511faadc22bd13c31 Reviewed-on: https://webrtc-review.googlesource.com/52161 Reviewed-by: Taylor Brandstetter Cr-Commit-Position: refs/heads/master@{#21992} --- call/rampup_tests.cc | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/call/rampup_tests.cc b/call/rampup_tests.cc index d0354168cf..3a85214688 100644 --- a/call/rampup_tests.cc +++ b/call/rampup_tests.cc @@ -598,7 +598,15 @@ TEST_F(RampUpTest, DISABLED_UpDownUpTransportSequenceNumberPacketLoss) { RunBaseTest(&test); } -TEST_F(RampUpTest, UpDownUpAudioVideoTransportSequenceNumberRtx) { +// TODO(bugs.webrtc.org/8878) +#if defined(WEBRTC_MAC) +#define MAYBE_UpDownUpAudioVideoTransportSequenceNumberRtx \ + DISABLED_UpDownUpAudioVideoTransportSequenceNumberRtx +#else +#define MAYBE_UpDownUpAudioVideoTransportSequenceNumberRtx \ + UpDownUpAudioVideoTransportSequenceNumberRtx +#endif +TEST_F(RampUpTest, MAYBE_UpDownUpAudioVideoTransportSequenceNumberRtx) { std::vector loss_rates = {0, 0, 0, 0}; RampUpDownUpTester test(3, 1, 0, kStartBitrateBps, RtpExtension::kTransportSequenceNumberUri, true, @@ -650,7 +658,13 @@ TEST_F(RampUpTest, TransportSequenceNumberSimulcastRedRtx) { RunBaseTest(&test); } -TEST_F(RampUpTest, AudioTransportSequenceNumber) { +// TODO(bugs.webrtc.org/8878) +#if defined(WEBRTC_MAC) +#define MAYBE_AudioTransportSequenceNumber DISABLED_AudioTransportSequenceNumber +#else +#define MAYBE_AudioTransportSequenceNumber AudioTransportSequenceNumber +#endif +TEST_F(RampUpTest, MAYBE_AudioTransportSequenceNumber) { RampUpTester test(0, 1, 0, 300000, 10000, RtpExtension::kTransportSequenceNumberUri, false, false, false);