From ab4f1c1bceff064acf69990fade85fc3f1afd48b Mon Sep 17 00:00:00 2001 From: Karl Wiberg Date: Fri, 4 May 2018 10:42:28 +0200 Subject: [PATCH] Be more clever when passing default arguments in log statements Default argument values are taken care of at the call site. If we switch to a separate overload, all of those call sites won't have to pass the default values, saving a few instructions each time. In aggregate, this reduces the size of libjingle_peerconnection_so.so by 12 kB. Bug: webrtc:9185 Change-Id: I8c792c7c6e5b230376dd129d16d9ed2541444d88 Reviewed-on: https://webrtc-review.googlesource.com/74440 Reviewed-by: Jonas Olsson Reviewed-by: Fredrik Solenberg Commit-Queue: Karl Wiberg Cr-Commit-Position: refs/heads/master@{#23112} --- rtc_base/logging.cc | 3 +++ rtc_base/logging.h | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/rtc_base/logging.cc b/rtc_base/logging.cc index ec8cd7ff4a..8eae4b7330 100644 --- a/rtc_base/logging.cc +++ b/rtc_base/logging.cc @@ -96,6 +96,9 @@ LogMessage::StreamList LogMessage::streams_ RTC_GUARDED_BY(g_log_crit); // Boolean options default to false (0) bool LogMessage::thread_, LogMessage::timestamp_; +LogMessage::LogMessage(const char* file, int line, LoggingSeverity sev) + : LogMessage(file, line, sev, ERRCTX_NONE, 0) {} + LogMessage::LogMessage(const char* file, int line, LoggingSeverity sev, diff --git a/rtc_base/logging.h b/rtc_base/logging.h index efaadc5af1..82960a48dd 100644 --- a/rtc_base/logging.h +++ b/rtc_base/logging.h @@ -121,11 +121,12 @@ class LogSink { class LogMessage { public: + LogMessage(const char* file, int line, LoggingSeverity sev); LogMessage(const char* file, int line, LoggingSeverity sev, - LogErrorContext err_ctx = ERRCTX_NONE, - int err = 0); + LogErrorContext err_ctx, + int err); #if defined(WEBRTC_ANDROID) LogMessage(const char* file, int line, LoggingSeverity sev, const char* tag);