From ab0d03dcaaa98677348d15352f7bc1e8e066180f Mon Sep 17 00:00:00 2001 From: Evan Shrubsole Date: Fri, 8 Mar 2019 11:20:04 +0100 Subject: [PATCH] Reland "DCHECK feedback_rtt is positive" This is a reland of 37d4f91db3fd1d0e023a820d0cda86bb786a0f72 Reason for reland: Got Aliby for Android FEC test flakes. Original change's description: > DCHECK feedback_rtt is positive > > Bug: None > Change-Id: I6eb10d6a20a679fff08f604441f8e58dcd417608 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126464 > Commit-Queue: Evan Shrubsole > Reviewed-by: Sebastian Jansson > Cr-Commit-Position: refs/heads/master@{#27034} Bug: None Change-Id: Iacacda9e3b141c69189f7931a1ec63d74b2dd845 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126920 Commit-Queue: Sebastian Jansson Reviewed-by: Ying Wang Reviewed-by: Sebastian Jansson Cr-Commit-Position: refs/heads/master@{#27082} --- modules/congestion_controller/goog_cc/goog_cc_network_control.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/congestion_controller/goog_cc/goog_cc_network_control.cc b/modules/congestion_controller/goog_cc/goog_cc_network_control.cc index 283ca983e9..7f331da0b9 100644 --- a/modules/congestion_controller/goog_cc/goog_cc_network_control.cc +++ b/modules/congestion_controller/goog_cc/goog_cc_network_control.cc @@ -381,6 +381,7 @@ NetworkControlUpdate GoogCcNetworkController::OnTransportPacketsFeedback( for (const auto& feedback : feedbacks) { TimeDelta feedback_rtt = report.feedback_time - feedback.sent_packet.send_time; + RTC_DCHECK_GE(feedback_rtt.ms(), 0); TimeDelta min_pending_time = feedback.receive_time - max_recv_time; TimeDelta propagation_rtt = feedback_rtt - min_pending_time; max_feedback_rtt = std::max(max_feedback_rtt, feedback_rtt);