From aae7e7cf35a5bb43ebbaf75396aa7ccc544e920a Mon Sep 17 00:00:00 2001
From: magjed <magjed@webrtc.org>
Date: Thu, 17 Nov 2016 07:29:31 -0800
Subject: [PATCH] Split out target rtc_media_base from rtc_media

The purpose with this CL is to be able to depend on
cricket::VideoCodec (webrtc/media/base/codec.h) from other targets
without getting cyclic dependencies.

BUG=webrtc:6402,webrtc:6337

NOTRY=True

Review-Url: https://codereview.webrtc.org/2471573003
Cr-Commit-Position: refs/heads/master@{#15137}
---
 webrtc/media/BUILD.gn      | 38 +++++++++++++++++++++++++++++++++++---
 webrtc/media/base/codec.cc |  6 +++---
 2 files changed, 38 insertions(+), 6 deletions(-)

diff --git a/webrtc/media/BUILD.gn b/webrtc/media/BUILD.gn
index 590450bd29..695cb8d5d0 100644
--- a/webrtc/media/BUILD.gn
+++ b/webrtc/media/BUILD.gn
@@ -12,6 +12,7 @@ import("../build/webrtc.gni")
 group("media") {
   public_deps = [
     ":rtc_media",
+    ":rtc_media_base",
   ]
 }
 
@@ -41,7 +42,7 @@ if (is_linux && rtc_use_gtk) {
   }
 }
 
-rtc_static_library("rtc_media") {
+rtc_static_library("rtc_media_base") {
   defines = []
   libs = []
   deps = []
@@ -81,6 +82,38 @@ rtc_static_library("rtc_media") {
     "base/videoframe.h",
     "base/videosourcebase.cc",
     "base/videosourcebase.h",
+  ]
+
+  configs += [ ":rtc_media_warnings_config" ]
+
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+  }
+
+  include_dirs = []
+  if (rtc_build_libyuv) {
+    deps += [ "$rtc_libyuv_dir" ]
+    public_deps = [
+      "$rtc_libyuv_dir",
+    ]
+  } else {
+    # Need to add a directory normally exported by libyuv.
+    include_dirs += [ "$rtc_libyuv_dir/include" ]
+  }
+
+  deps += [
+    "..:webrtc_common",
+    "../base:rtc_base_approved",
+    "../p2p",
+  ]
+}
+
+rtc_static_library("rtc_media") {
+  defines = []
+  libs = []
+  deps = []
+  sources = [
     "engine/internalencoderfactory.cc",
     "engine/internalencoderfactory.h",
     "engine/nullwebrtcvideoengine.h",
@@ -166,15 +199,14 @@ rtc_static_library("rtc_media") {
     public_configs += [ ":gtk-lib" ]
   }
   deps += [
+    ":rtc_media_base",
     "..:webrtc_common",
     "../api:call_api",
     "../base:rtc_base_approved",
     "../call",
     "../modules/audio_mixer:audio_mixer_impl",
     "../modules/video_coding",
-    "../p2p",
     "../system_wrappers",
-    "../video",
     "../voice_engine",
   ]
 }
diff --git a/webrtc/media/base/codec.cc b/webrtc/media/base/codec.cc
index 0320e58c72..aac21002b6 100644
--- a/webrtc/media/base/codec.cc
+++ b/webrtc/media/base/codec.cc
@@ -13,7 +13,7 @@
 #include <algorithm>
 #include <sstream>
 
-#include "webrtc/base/common.h"
+#include "webrtc/base/checks.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/stringencode.h"
 #include "webrtc/base/stringutils.h"
@@ -54,7 +54,7 @@ void FeedbackParams::Add(const FeedbackParam& param) {
     return;
   }
   params_.push_back(param);
-  ASSERT(!HasDuplicateEntries());
+  RTC_CHECK(!HasDuplicateEntries());
 }
 
 void FeedbackParams::Intersect(const FeedbackParams& from) {
@@ -192,7 +192,7 @@ bool AudioCodec::Matches(const AudioCodec& codec) const {
 
 webrtc::RtpCodecParameters AudioCodec::ToCodecParameters() const {
   webrtc::RtpCodecParameters codec_params = Codec::ToCodecParameters();
-  codec_params.channels = channels;
+  codec_params.channels = static_cast<int>(channels);
   return codec_params;
 }