From aa0e56e8e8384dea0a2dea2945d019777371577f Mon Sep 17 00:00:00 2001 From: "stefan@webrtc.org" Date: Thu, 26 Jun 2014 11:44:49 +0000 Subject: [PATCH] Fixes a bug causing NACKs to be dropped excessively at the send-side. This was introduced in r6472 where the target bitrate was changed to be stored in bits/s instead of kbits/s, but the storage type was accidentally left as uint16_t. This caused the bitrate to be truncated, which at times causes NACKs to be dropped due to insufficient bitrate available. BUG=3518 TEST=Tested in Chrome, trybots and verified that it fixes the bug in vie_auto_test loopback test. R=mflodman@webrtc.org Review URL: https://webrtc-codereview.appspot.com/21739004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6544 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/modules/rtp_rtcp/source/rtp_sender.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.h b/webrtc/modules/rtp_rtcp/source/rtp_sender.h index 17b026cada..291e619b43 100644 --- a/webrtc/modules/rtp_rtcp/source/rtp_sender.h +++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.h @@ -397,7 +397,7 @@ class RTPSender : public RTPSenderInterface, public Bitrate::Observer { // that by the time the function returns there is no guarantee // that the target bitrate is still valid. scoped_ptr target_bitrate_critsect_; - uint16_t target_bitrate_ GUARDED_BY(target_bitrate_critsect_); + uint32_t target_bitrate_ GUARDED_BY(target_bitrate_critsect_); }; } // namespace webrtc