admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RefCounter::DecRef: Remove obsolete TODO and update comment

Browse Source 
Bug: webrtc:10198
Change-Id: Icbcb849bdc789d9e3bb7ea6a902475a8263980bf
Reviewed-on: https://webrtc-review.googlesource.com/c/117300
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26242}
This commit is contained in:
Karl Wiberg 2019-01-14 13:18:31 +01:00 committed by Commit Bot
parent ebd9770b05
commit a8c7326524
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
rtc_base/ref_counter.h
View File

@ -23,9 +23,11 @@ class RefCounter {
void IncRef() { rtc::AtomicOps::Increment(&ref_count_); } void IncRef() { rtc::AtomicOps::Increment(&ref_count_); }
// TODO(nisse): Switch return type to RefCountReleaseStatus? // Returns kDroppedLastRef if this call dropped the last reference; the caller
// Returns true if this was the last reference, and the resource protected by // should therefore free the resource protected by the reference counter.
// the reference counter can be deleted. // Otherwise, returns kOtherRefsRemained (note that in case of multithreading,
// some other caller may have dropped the last reference by the time this call
// returns; all we know is that we didn't do it).
rtc::RefCountReleaseStatus DecRef() { rtc::RefCountReleaseStatus DecRef() {
return (rtc::AtomicOps::Decrement(&ref_count_) == 0) return (rtc::AtomicOps::Decrement(&ref_count_) == 0)
? rtc::RefCountReleaseStatus::kDroppedLastRef ? rtc::RefCountReleaseStatus::kDroppedLastRef