admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix explicit ref pointer conversion of MediaStream::AddTrack

Browse Source 
Previous cl https://webrtc-review.googlesource.com/c/src/+/244090
incorrectly updated the RemoveTrack instead of the AddTrack method,
for audio tracks.

Bug: webrtc:13464
Change-Id: If1c7688c88c4712a3bc9533aa9c7a9b22e87ac8d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244502
Commit-Queue: Niels Moller <nisse@webrtc.org>
Auto-Submit: Niels Moller <nisse@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35629}
This commit is contained in:
Niels Möller 2022-01-05 09:31:48 +01:00 committed by WebRTC LUCI CQ
parent 9abd74dc1e
commit a89432f94b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pc/media_stream.cc
View File

@ -38,7 +38,8 @@ rtc::scoped_refptr<MediaStream> MediaStream::Create(const std::string& id) {
MediaStream::MediaStream(const std::string& id) : id_(id) {}
bool MediaStream::AddTrack(AudioTrackInterface* track) {
return AddTrack<AudioTrackVector, AudioTrackInterface>(&audio_tracks_, track);
return AddTrack<AudioTrackVector, AudioTrackInterface>(
&audio_tracks_, rtc::scoped_refptr<AudioTrackInterface>(track));
}
bool MediaStream::AddTrack(VideoTrackInterface* track) {
@ -47,8 +48,7 @@ bool MediaStream::AddTrack(VideoTrackInterface* track) {
}
bool MediaStream::RemoveTrack(AudioTrackInterface* track) {
return RemoveTrack<AudioTrackVector>(
&audio_tracks_, rtc::scoped_refptr<AudioTrackInterface>(track));
return RemoveTrack<AudioTrackVector>(&audio_tracks_, track);
}
bool MediaStream::RemoveTrack(VideoTrackInterface* track) {