From a79abd40545c4e32907de7c60555443ba6d41133 Mon Sep 17 00:00:00 2001 From: Oleh Prypin Date: Tue, 25 Jun 2019 23:19:17 +0200 Subject: [PATCH] Specify min_sdk_version for unittest apks also in GN configs This is a followup to https://webrtc-review.googlesource.com/142235 This was missed and it fails the new assert in https://chromium-review.googlesource.com/1675323 Example of failing roll: https://webrtc-review.googlesource.com/143844 This comes with the same caveats, i.e. the information is duplicated in AndroidManifest. But the new assert prevents de-sync between them :) The version is being specified unconditionally because so is AndroidManifest. Bug: chromium:891996 Change-Id: I92a2011c8fda55849bd9ba8df619f897f48e58da Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143795 Reviewed-by: Mirko Bonadei Commit-Queue: Oleh Prypin Cr-Commit-Position: refs/heads/master@{#28378} --- webrtc.gni | 1 + 1 file changed, 1 insertion(+) diff --git a/webrtc.gni b/webrtc.gni index d7cc2389a0..9e13283ec0 100644 --- a/webrtc.gni +++ b/webrtc.gni @@ -401,6 +401,7 @@ template("rtc_test") { } if (!build_with_chromium && is_android) { android_manifest = webrtc_root + "test/android/AndroidManifest.xml" + min_sdk_version = 16 deps += [ webrtc_root + "test:native_test_java" ] } }