From a7066a35ba9317d9ce04f52b8242eb80aa28dc5d Mon Sep 17 00:00:00 2001 From: kjellander Date: Thu, 23 Mar 2017 03:47:05 -0700 Subject: [PATCH] PRESUBMIT: Improve error message about checkdeps. This will make it easier for new project members to know what's causing the error. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2770883004 Cr-Commit-Position: refs/heads/master@{#17358} --- PRESUBMIT.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index b5067bf8e6..994fcf4c75 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -409,13 +409,18 @@ def _CheckUnwantedDependencies(input_api, output_api): results = [] if error_descriptions: results.append(output_api.PresubmitError( - 'You added one or more #includes that violate checkdeps rules.', + 'You added one or more #includes that violate checkdeps rules.\n' + 'Check that the DEPS files in these locations contain valid rules.\n' + 'See https://cs.chromium.org/chromium/src/buildtools/checkdeps/ for ' + 'more details about checkdeps.', error_descriptions)) if warning_descriptions: results.append(output_api.PresubmitPromptOrNotify( 'You added one or more #includes of files that are temporarily\n' 'allowed but being removed. Can you avoid introducing the\n' - '#include? See relevant DEPS file(s) for details and contacts.', + '#include? See relevant DEPS file(s) for details and contacts.\n' + 'See https://cs.chromium.org/chromium/src/buildtools/checkdeps/ for ' + 'more details about checkdeps.', warning_descriptions)) return results