admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Eliminate a temporary std::string in ParsedFailed helper.

Browse Source 
Bug: None
Change-Id: If3435b5e9da9d2049c9b82b8b68e54d1ecc69003
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233440
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35125}
This commit is contained in:
Niels Möller 2021-09-30 08:48:05 +02:00 committed by WebRTC LUCI CQ
parent 82ccdd36aa
commit a654e07d11
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pc/webrtc_sdp.cc
View File

@ -415,7 +415,9 @@ static bool ParseFailed(absl::string_view message,
RTC_LOG(LS_ERROR) << "Failed to parse: \"" << first_line
<< "\". Reason: " << description;
if (error) {
error->line = std::string(first_line);
// TODO(bugs.webrtc.org/13220): In C++17, we can use plain assignment, with
// a string_view on the right hand side.
error->line.assign(first_line.data(), first_line.size());
error->description = std::move(description);
}
return false;