admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correct format for TODO comments

Browse Source 
Bug: webrtc:358039777
Change-Id: Iad5f8867bcbca883b16617819ea24a965160d23e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/363802
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43089}
This commit is contained in:
Fanny Linderborg 2024-09-26 11:05:23 +02:00 committed by WebRTC LUCI CQ
parent 7528d4ba52
commit a61a25a0b1
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common_video/frame_instrumentation_data.h
View File

@ -15,7 +15,7 @@
namespace webrtc { namespace webrtc {
// TODO: b/358039777 - Error handling: negative values etc. // TODO: bugs.webrtc.org/358039777 - Error handling: negative values etc.
struct FrameInstrumentationSyncData { struct FrameInstrumentationSyncData {
int sequence_index; int sequence_index;
bool communicate_upper_bits; bool communicate_upper_bits;

3
media/engine/webrtc_video_engine.cc
View File

@ -1495,7 +1495,8 @@ bool WebRtcVideoSendChannel::AddSendStream(const StreamParams& sp) {
bitrate_allocator_factory_; bitrate_allocator_factory_;
config.encoder_settings.encoder_switch_request_callback = this; config.encoder_settings.encoder_switch_request_callback = this;
// TODO: b/358039777 - Add test when this effectively does something. // TODO: bugs.webrtc.org/358039777 - Add test when this effectively does
// something.
if (webrtc::RtpExtension::FindHeaderExtensionByUri( if (webrtc::RtpExtension::FindHeaderExtensionByUri(
config.rtp.extensions, webrtc::RtpExtension::kCorruptionDetectionUri, config.rtp.extensions, webrtc::RtpExtension::kCorruptionDetectionUri,
webrtc::RtpExtension::kRequireEncryptedExtension)) { webrtc::RtpExtension::kRequireEncryptedExtension)) {

5
video/corruption_detection/frame_instrumentation_generator.cc
View File

@ -40,7 +40,8 @@ std::optional<FilterSettings> GetCorruptionFilterSettings(
const EncodedImage& encoded_image, const EncodedImage& encoded_image,
VideoCodecType video_codec_type, VideoCodecType video_codec_type,
int layer_id) { int layer_id) {
/* TODO: b/358039777 - Uncomment when parameters are available in EncodedImage /* TODO: bugs.webrtc.org/358039777 - Uncomment when parameters are available
in EncodedImage.
if (encoded_image.CorruptionDetectionParameters()) { if (encoded_image.CorruptionDetectionParameters()) {
return FilterSettings{ return FilterSettings{
.std_dev = encoded_image.CorruptionDetectionParameters()->std_dev, .std_dev = encoded_image.CorruptionDetectionParameters()->std_dev,
@ -136,7 +137,7 @@ FrameInstrumentationGenerator::OnEncodedImage(
contexts_[layer_id].frame_sampler.SetCurrentIndex(sequence_index); contexts_[layer_id].frame_sampler.SetCurrentIndex(sequence_index);
} }
// TODO: b/358039777 - Maybe allow other sample sizes as well // TODO: bugs.webrtc.org/358039777 - Maybe allow other sample sizes as well
std::vector<HaltonFrameSampler::Coordinates> sample_coordinates = std::vector<HaltonFrameSampler::Coordinates> sample_coordinates =
contexts_[layer_id] contexts_[layer_id]
.frame_sampler.GetSampleCoordinatesForFrameIfFrameShouldBeSampled( .frame_sampler.GetSampleCoordinatesForFrameIfFrameShouldBeSampled(