admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove deprecated TransformableVideoFrame::GetAdditionalData

Browse Source 
It was marked deprecated on Feb 9th, ~3 weeks ago.

Bug: chromium:1414370
Change-Id: I251b91984ca9a958e221f6eaf01c63b05c5a7a48
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295506
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tony Herre <herre@google.com>
Cr-Commit-Position: refs/heads/main@{#39422}
This commit is contained in:
Tony Herre 2023-02-28 14:57:04 +01:00 committed by WebRTC LUCI CQ
parent c65f5fd90f
commit a6135bcd43
4 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
api/frame_transformer_interface.h
View File

@ -58,14 +58,6 @@ class TransformableVideoFrameInterface : public TransformableFrameInterface {
virtual ~TransformableVideoFrameInterface() = default;
virtual bool IsKeyFrame() const = 0;
// Returns data needed in the frame transformation logic; for example,
// when the transformation applied to the frame is encryption/decryption, the
// additional data holds the serialized generic frame descriptor extension
// calculated in webrtc::RtpDescriptorAuthentication.
// This has been superseeded by GetMetadata() and will be removed shortly.
[[deprecated("https://crbug.com/1414370")]] virtual std::vector<uint8_t>
GetAdditionalData() const = 0;
// The returned const ref may become invalid due to later SetMetadata calls,
// or other modifications. Use Metadata() instead.
virtual const VideoFrameMetadata& GetMetadata() const = 0;

1
api/test/mock_transformable_video_frame.h
View File

@ -26,7 +26,6 @@ class MockTransformableVideoFrame
MOCK_METHOD(uint32_t, GetTimestamp, (), (const, override));
MOCK_METHOD(uint32_t, GetSsrc, (), (const, override));
MOCK_METHOD(bool, IsKeyFrame, (), (const, override));
MOCK_METHOD(std::vector<uint8_t>, GetAdditionalData, (), (const, override));
MOCK_METHOD(const webrtc::VideoFrameMetadata&,
GetMetadata,
(),

4
modules/rtp_rtcp/source/rtp_sender_video_frame_transformer_delegate.cc
View File

@ -66,10 +66,6 @@ class TransformableVideoSenderFrame : public TransformableVideoFrameInterface {
return frame_type_ == VideoFrameType::kVideoFrameKey;
}
std::vector<uint8_t> GetAdditionalData() const override {
return RtpDescriptorAuthentication(header_);
}
const VideoFrameMetadata& GetMetadata() const override { return metadata_; }
VideoFrameMetadata Metadata() const override {

4
modules/rtp_rtcp/source/rtp_video_stream_receiver_frame_transformer_delegate.cc
View File

@ -51,10 +51,6 @@ class TransformableVideoReceiverFrame
return frame_->FrameType() == VideoFrameType::kVideoFrameKey;
}
std::vector<uint8_t> GetAdditionalData() const override {
return RtpDescriptorAuthentication(frame_->GetRtpVideoHeader());
}
const VideoFrameMetadata& GetMetadata() const override { return metadata_; }
VideoFrameMetadata Metadata() const override { return metadata_; }