From a5e8aa6e2b9b8cdc6d7d5120fc64c08e4036bf03 Mon Sep 17 00:00:00 2001 From: jianj Date: Mon, 27 Mar 2017 10:09:00 -0700 Subject: [PATCH] Vp9: Enable denoiser by default. BUG=webrtc:7412 Review-Url: https://codereview.webrtc.org/2765663002 Cr-Commit-Position: refs/heads/master@{#17395} --- webrtc/media/engine/webrtcvideoengine2.cc | 2 +- webrtc/media/engine/webrtcvideoengine2_unittest.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc index f5682edfe6..f4b4b6f790 100644 --- a/webrtc/media/engine/webrtcvideoengine2.cc +++ b/webrtc/media/engine/webrtcvideoengine2.cc @@ -409,7 +409,7 @@ WebRtcVideoChannel2::WebRtcVideoSendStream::ConfigureVideoEncoderSettings( vp9_settings.numberOfSpatialLayers = GetDefaultVp9SpatialLayers(); } // VP9 denoising is disabled by default. - vp9_settings.denoisingOn = codec_default_denoising ? false : denoising; + vp9_settings.denoisingOn = codec_default_denoising ? true : denoising; vp9_settings.frameDroppingOn = frame_dropping; return new rtc::RefCountedObject< webrtc::VideoEncoderConfig::Vp9EncoderSpecificSettings>(vp9_settings); diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc index 47f912b196..395d6ed291 100644 --- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc +++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc @@ -1971,8 +1971,8 @@ TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) { webrtc::VideoCodecVP9 vp9_settings; ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set."; - EXPECT_FALSE(vp9_settings.denoisingOn) - << "VP9 denoising should be off by default."; + EXPECT_TRUE(vp9_settings.denoisingOn) + << "VP9 denoising should be on by default."; stream = SetDenoisingOption(last_ssrc_, &capturer, false);