admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change scale factor to 0.5

Browse Source 
The tests shows that using a scale factor around 0.5 gives the best precision and F1 score.

Bug: webrtc:358039777
Change-Id: I22557eb9e6318ecaa726b56d3ccb2125fdf65f7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367681
Reviewed-by: Fanny Linderborg <linderborg@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Emil Vardar (xWF) <vardar@google.com>
Cr-Commit-Position: refs/heads/main@{#43366}
This commit is contained in:
Emil Vardar 2024-11-06 09:56:18 +00:00 committed by WebRTC LUCI CQ
parent 69af473a8a
commit a5676c17b3
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
video/corruption_detection/frame_instrumentation_evaluation.cc
View File

@ -85,9 +85,7 @@ std::optional<double> GetCorruptionScore(const FrameInstrumentationData& data,
return std::nullopt;
}
// TODO: bugs.webrtc.org/358039777 - Update before rollout. Which variant of
// classifier should we use? What input parameters should it have?
CorruptionClassifier classifier(2.5);
CorruptionClassifier classifier(0.5);
return classifier.CalculateCorruptionProbability(data_samples, samples,
data.luma_error_threshold,

9
video/corruption_detection/frame_instrumentation_evaluation_unittest.cc
View File

@ -94,7 +94,8 @@ TEST(FrameInstrumentationEvaluationTest,
std::optional<double> corruption_score = GetCorruptionScore(data, frame);
ASSERT_TRUE(corruption_score.has_value());
EXPECT_DOUBLE_EQ(*corruption_score, 0.55);
EXPECT_LE(*corruption_score, 1);
EXPECT_GE(*corruption_score, 0);
}
TEST(FrameInstrumentationEvaluationTest,
@ -116,7 +117,8 @@ TEST(FrameInstrumentationEvaluationTest,
std::optional<double> corruption_score = GetCorruptionScore(data, frame);
ASSERT_TRUE(corruption_score.has_value());
EXPECT_DOUBLE_EQ(*corruption_score, 0.3302493109581533);
EXPECT_LE(*corruption_score, 1);
EXPECT_GE(*corruption_score, 0);
}
TEST(FrameInstrumentationEvaluationTest, ApplySequenceIndexWhenProvided) {
@ -137,7 +139,8 @@ TEST(FrameInstrumentationEvaluationTest, ApplySequenceIndexWhenProvided) {
std::optional<double> corruption_score = GetCorruptionScore(data, frame);
ASSERT_TRUE(corruption_score.has_value());
EXPECT_DOUBLE_EQ(*corruption_score, 0.12983429453668965);
EXPECT_LE(*corruption_score, 1);
EXPECT_GE(*corruption_score, 0);
}
} // namespace