From a54ba4c02e5111ac5fbce32af004e2b4c4ba49c9 Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Mon, 11 May 2020 12:36:13 +0200 Subject: [PATCH] Make video_loopback work with av1 Bug: webrtc:11404 Change-Id: Id4fb4ac7e545df2e4f0a0d91b3531074ff77c9f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172340 Reviewed-by: Ilya Nikolaevskiy Commit-Queue: Danil Chapovalov Cr-Commit-Position: refs/heads/master@{#31210} --- video/BUILD.gn | 1 + video/video_quality_test.cc | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/video/BUILD.gn b/video/BUILD.gn index 933f676b1f..bfc3b0695c 100644 --- a/video/BUILD.gn +++ b/video/BUILD.gn @@ -303,6 +303,7 @@ if (rtc_include_tests) { "../media:rtc_audio_video", "../media:rtc_encoder_simulcast_proxy", "../media:rtc_internal_video_codecs", + "../media:rtc_media_base", "../modules/audio_device:audio_device_api", "../modules/audio_device:audio_device_module_from_input_and_output", "../modules/audio_device:windows_core_audio_utility", diff --git a/video/video_quality_test.cc b/video/video_quality_test.cc index a8f475abdf..94ce268fa9 100644 --- a/video/video_quality_test.cc +++ b/video/video_quality_test.cc @@ -31,6 +31,7 @@ #include "api/video_codecs/video_encoder.h" #include "call/fake_network_pipe.h" #include "call/simulated_network.h" +#include "media/base/media_constants.h" #include "media/engine/adm_helpers.h" #include "media/engine/encoder_simulcast_proxy.h" #include "media/engine/fake_video_codec_factory.h" @@ -937,6 +938,10 @@ void VideoQualityTest::SetupVideo(Transport* send_transport, VideoEncoderConfig::Vp9EncoderSpecificSettings>(vp9_settings); } else if (params_.video[video_idx].codec == "H264") { // Quality scaling is always on for H.264. + } else if (params_.video[video_idx].codec == cricket::kAv1CodecName) { + // TODO(bugs.webrtc.org/11404): Propagate the flag to + // aom_codec_enc_cfg_t::rc_resize_mode in Av1 encoder wrapper. + // Until then do nothing, specially do not crash. } else { RTC_NOTREACHED() << "Automatic scaling not supported for codec " << params_.video[video_idx].codec << ", stream "