From a52fc6f940ae22c7781dcbf2ff765ea648e98c04 Mon Sep 17 00:00:00 2001 From: Harald Alvestrand Date: Fri, 5 Nov 2021 11:45:08 +0000 Subject: [PATCH] Increase loss tolerance for RenegotiateManyVideo test. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Also switch to "LT(meaured, limit)" format as this is easier to read. There have been bot runs that exceeded the old limit. Bug: webrtc:13354 Change-Id: I1c19c98e1c1777177e7dc14ae4679765c1c40550 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237342 Reviewed-by: Björn Terelius Commit-Queue: Harald Alvestrand Cr-Commit-Position: refs/heads/main@{#35317} --- pc/test/integration_test_helpers.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pc/test/integration_test_helpers.h b/pc/test/integration_test_helpers.h index a978eda4ef..6c60ba81ab 100644 --- a/pc/test/integration_test_helpers.h +++ b/pc/test/integration_test_helpers.h @@ -659,15 +659,15 @@ class PeerConnectionIntegrationWrapper : public webrtc::PeerConnectionObserver, // Concealing more than 20% of samples during a renegotiation is // unacceptable. // Worst bots: - // linux_more_configs bot at conceal rate 0.516 - // linux_x86_dbg bot at conceal rate 0.854 + // Nondebug: Linux32 Release at conceal rate 0.606597 (CI run) + // Debug: linux_x86_dbg bot at conceal rate 0.854 if (delta_samples > 0) { #if !defined(NDEBUG) - EXPECT_GT(0.95, 1.0 * delta_concealed / delta_samples) + EXPECT_LT(1.0 * delta_concealed / delta_samples, 0.95) << "Concealed " << delta_concealed << " of " << delta_samples << " samples"; #else - EXPECT_GT(0.6, 1.0 * delta_concealed / delta_samples) + EXPECT_LT(1.0 * delta_concealed / delta_samples, 0.7) << "Concealed " << delta_concealed << " of " << delta_samples << " samples"; #endif