admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add unit test framework for DataChannelController

Browse Source 
This is in pursuit of an issue with another CL, but large enough
to be worth submitting separately.

Bug: webrtc:13931
Change-Id: If470488f092f8640d3a773922f6f0d22765b9e97
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261728
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36833}
This commit is contained in:
Harald Alvestrand 2022-05-10 08:44:48 +00:00 committed by WebRTC LUCI CQ
parent e00d7d0ce6
commit a45c8f4469
3 changed files with 398 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pc/BUILD.gn
View File

@ -2348,6 +2348,7 @@ if (rtc_include_tests && !build_with_chromium) {
":channel",
":channel_interface",
":channel_manager",
":data_channel_controller_unittest",
":dtls_srtp_transport",
":dtls_transport",
":dtmf_sender",
@ -2516,6 +2517,17 @@ if (rtc_include_tests && !build_with_chromium) {
]
}
rtc_library("data_channel_controller_unittest") {
testonly = true
sources = [ "data_channel_controller_unittest.cc" ]
deps = [
":data_channel_controller",
":pc_test_utils",
":peer_connection_internal",
"../test:test_support",
]
}
if (is_android) {
rtc_library("android_black_magic") {
# The android code uses hacky includes to ssl code. Having this in a
@ -2670,6 +2682,7 @@ if (rtc_include_tests && !build_with_chromium) {
"test/frame_generator_capturer_video_track_source.h",
"test/mock_channel_interface.h",
"test/mock_data_channel.h",
"test/mock_peer_connection_internal.h",
"test/mock_peer_connection_observers.h",
"test/mock_rtp_receiver_internal.h",
"test/mock_rtp_sender_internal.h",

60
pc/data_channel_controller_unittest.cc Normal file
View File

@ -0,0 +1,60 @@
/*
* Copyright 2022 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "pc/data_channel_controller.h"
#include <memory>
#include "pc/peer_connection_internal.h"
#include "pc/test/mock_peer_connection_internal.h"
#include "test/gmock.h"
#include "test/gtest.h"
namespace webrtc {
namespace {
using ::testing::NiceMock;
using ::testing::Return;
class DataChannelControllerTest : public ::testing::Test {
protected:
DataChannelControllerTest() {
pc_ = rtc::make_ref_counted<NiceMock<MockPeerConnectionInternal>>();
ON_CALL(*pc_, signaling_thread)
.WillByDefault(Return(rtc::Thread::Current()));
}
rtc::scoped_refptr<NiceMock<MockPeerConnectionInternal>> pc_;
};
TEST_F(DataChannelControllerTest, CreateAndDestroy) {
DataChannelController dcc(pc_.get());
}
TEST_F(DataChannelControllerTest, CreateDataChannelEarlyRelease) {
DataChannelController dcc(pc_.get());
auto channel = dcc.InternalCreateDataChannelWithProxy(
"label",
std::make_unique<InternalDataChannelInit>(DataChannelInit()).get());
channel = nullptr; // Should call destructor of channel
}
TEST_F(DataChannelControllerTest, CreateDataChannelLateRelease) {
auto dcc = std::make_unique<DataChannelController>(pc_.get());
auto channel = dcc->InternalCreateDataChannelWithProxy(
"label",
std::make_unique<InternalDataChannelInit>(DataChannelInit()).get());
dcc.reset();
channel = nullptr;
}
} // namespace
} // namespace webrtc

325
pc/test/mock_peer_connection_internal.h Normal file
View File

@ -0,0 +1,325 @@
/*
* Copyright 2022 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#ifndef PC_TEST_MOCK_PEER_CONNECTION_INTERNAL_H_
#define PC_TEST_MOCK_PEER_CONNECTION_INTERNAL_H_
#include <map>
#include <memory>
#include <set>
#include <string>
#include <vector>
#include "pc/peer_connection_internal.h"
#include "test/gmock.h"
namespace webrtc {
class MockPeerConnectionInternal : public PeerConnectionInternal {
public:
MockPeerConnectionInternal() {}
~MockPeerConnectionInternal() = default;
// PeerConnectionInterface
MOCK_METHOD(rtc::scoped_refptr<StreamCollectionInterface>,
local_streams,
(),
(override));
MOCK_METHOD(rtc::scoped_refptr<StreamCollectionInterface>,
remote_streams,
(),
(override));
MOCK_METHOD(bool, AddStream, (MediaStreamInterface*), (override));
MOCK_METHOD(void, RemoveStream, (MediaStreamInterface*), (override));
MOCK_METHOD(RTCErrorOr<rtc::scoped_refptr<RtpSenderInterface>>,
AddTrack,
(rtc::scoped_refptr<MediaStreamTrackInterface>,
const std::vector<std::string>&),
(override));
MOCK_METHOD(RTCError,
RemoveTrackOrError,
(rtc::scoped_refptr<RtpSenderInterface>),
(override));
MOCK_METHOD(RTCErrorOr<rtc::scoped_refptr<RtpTransceiverInterface>>,
AddTransceiver,
(rtc::scoped_refptr<MediaStreamTrackInterface>),
(override));
MOCK_METHOD(RTCErrorOr<rtc::scoped_refptr<RtpTransceiverInterface>>,
AddTransceiver,
(rtc::scoped_refptr<MediaStreamTrackInterface>,
const RtpTransceiverInit&),
(override));
MOCK_METHOD(RTCErrorOr<rtc::scoped_refptr<RtpTransceiverInterface>>,
AddTransceiver,
(cricket::MediaType),
(override));
MOCK_METHOD(RTCErrorOr<rtc::scoped_refptr<RtpTransceiverInterface>>,
AddTransceiver,
(cricket::MediaType, const RtpTransceiverInit&),
(override));
MOCK_METHOD(rtc::scoped_refptr<RtpSenderInterface>,
CreateSender,
(const std::string&, const std::string&),
(override));
MOCK_METHOD(std::vector<rtc::scoped_refptr<RtpSenderInterface>>,
GetSenders,
(),
(const, override));
MOCK_METHOD(std::vector<rtc::scoped_refptr<RtpReceiverInterface>>,
GetReceivers,
(),
(const, override));
MOCK_METHOD(std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>,
GetTransceivers,
(),
(const, override));
MOCK_METHOD(bool,
GetStats,
(StatsObserver*, MediaStreamTrackInterface*, StatsOutputLevel),
(override));
MOCK_METHOD(void, GetStats, (RTCStatsCollectorCallback*), (override));
MOCK_METHOD(void,
GetStats,
(rtc::scoped_refptr<RtpSenderInterface>,
rtc::scoped_refptr<RTCStatsCollectorCallback>),
(override));
MOCK_METHOD(void,
GetStats,
(rtc::scoped_refptr<RtpReceiverInterface>,
rtc::scoped_refptr<RTCStatsCollectorCallback>),
(override));
MOCK_METHOD(void, ClearStatsCache, (), (override));
MOCK_METHOD(RTCErrorOr<rtc::scoped_refptr<DataChannelInterface>>,
CreateDataChannelOrError,
(const std::string&, const DataChannelInit*),
(override));
MOCK_METHOD(SessionDescriptionInterface*,
local_description,
(),
(const, override));
MOCK_METHOD(SessionDescriptionInterface*,
remote_description,
(),
(const, override));
MOCK_METHOD(SessionDescriptionInterface*,
current_local_description,
(),
(const, override));
MOCK_METHOD(SessionDescriptionInterface*,
current_remote_description,
(),
(const, override));
MOCK_METHOD(SessionDescriptionInterface*,
pending_local_description,
(),
(const, override));
MOCK_METHOD(SessionDescriptionInterface*,
pending_remote_description,
(),
(const, override));
MOCK_METHOD(void, RestartIce, (), (override));
MOCK_METHOD(void,
CreateOffer,
(CreateSessionDescriptionObserver*, const RTCOfferAnswerOptions&),
(override));
MOCK_METHOD(void,
CreateAnswer,
(CreateSessionDescriptionObserver*, const RTCOfferAnswerOptions&),
(override));
MOCK_METHOD(void,
SetLocalDescription,
(SetSessionDescriptionObserver*, SessionDescriptionInterface*),
(override));
MOCK_METHOD(void,
SetRemoteDescription,
(SetSessionDescriptionObserver*, SessionDescriptionInterface*),
(override));
MOCK_METHOD(void,
SetRemoteDescription,
(std::unique_ptr<SessionDescriptionInterface>,
rtc::scoped_refptr<SetRemoteDescriptionObserverInterface>),
(override));
MOCK_METHOD(PeerConnectionInterface::RTCConfiguration,
GetConfiguration,
(),
(override));
MOCK_METHOD(RTCError,
SetConfiguration,
(const PeerConnectionInterface::RTCConfiguration&),
(override));
MOCK_METHOD(bool,
AddIceCandidate,
(const IceCandidateInterface*),
(override));
MOCK_METHOD(bool,
RemoveIceCandidates,
(const std::vector<cricket::Candidate>&),
(override));
MOCK_METHOD(RTCError, SetBitrate, (const BitrateSettings&), (override));
MOCK_METHOD(void, SetAudioPlayout, (bool), (override));
MOCK_METHOD(void, SetAudioRecording, (bool), (override));
MOCK_METHOD(rtc::scoped_refptr<DtlsTransportInterface>,
LookupDtlsTransportByMid,
(const std::string&),
(override));
MOCK_METHOD(rtc::scoped_refptr<SctpTransportInterface>,
GetSctpTransport,
(),
(const, override));
MOCK_METHOD(SignalingState, signaling_state, (), (override));
MOCK_METHOD(IceConnectionState, ice_connection_state, (), (override));
MOCK_METHOD(IceConnectionState,
standardized_ice_connection_state,
(),
(override));
MOCK_METHOD(PeerConnectionState, peer_connection_state, (), (override));
MOCK_METHOD(IceGatheringState, ice_gathering_state, (), (override));
MOCK_METHOD(absl::optional<bool>, can_trickle_ice_candidates, (), (override));
MOCK_METHOD(bool,
StartRtcEventLog,
(std::unique_ptr<RtcEventLogOutput>, int64_t),
(override));
MOCK_METHOD(bool,
StartRtcEventLog,
(std::unique_ptr<RtcEventLogOutput>),
(override));
MOCK_METHOD(void, StopRtcEventLog, (), (override));
MOCK_METHOD(void, Close, (), (override));
MOCK_METHOD(rtc::Thread*, signaling_thread, (), (const, override));
// PeerConnectionSdpMethods
MOCK_METHOD(std::string, session_id, (), (const, override));
MOCK_METHOD(bool, NeedsIceRestart, (const std::string&), (const, override));
MOCK_METHOD(absl::optional<std::string>, sctp_mid, (), (const, override));
MOCK_METHOD(PeerConnectionInterface::RTCConfiguration*,
configuration,
(),
(const, override));
MOCK_METHOD(void,
ReportSdpFormatReceived,
(const SessionDescriptionInterface&),
(override));
MOCK_METHOD(void,
ReportSdpBundleUsage,
(const SessionDescriptionInterface&),
(override));
MOCK_METHOD(PeerConnectionMessageHandler*, message_handler, (), (override));
MOCK_METHOD(RtpTransmissionManager*, rtp_manager, (), (override));
MOCK_METHOD(const RtpTransmissionManager*,
rtp_manager,
(),
(const, override));
MOCK_METHOD(bool, dtls_enabled, (), (const, override));
MOCK_METHOD(const PeerConnectionFactoryInterface::Options*,
options,
(),
(const, override));
MOCK_METHOD(CryptoOptions, GetCryptoOptions, (), (override));
MOCK_METHOD(JsepTransportController*, transport_controller_s, (), (override));
MOCK_METHOD(JsepTransportController*, transport_controller_n, (), (override));
MOCK_METHOD(DataChannelController*, data_channel_controller, (), (override));
MOCK_METHOD(cricket::PortAllocator*, port_allocator, (), (override));
MOCK_METHOD(StatsCollector*, stats, (), (override));
MOCK_METHOD(PeerConnectionObserver*, Observer, (), (const, override));
MOCK_METHOD(bool, GetSctpSslRole, (rtc::SSLRole*), (override));
MOCK_METHOD(PeerConnectionInterface::IceConnectionState,
ice_connection_state_internal,
(),
(override));
MOCK_METHOD(void,
SetIceConnectionState,
(PeerConnectionInterface::IceConnectionState),
(override));
MOCK_METHOD(void, NoteUsageEvent, (UsageEvent), (override));
MOCK_METHOD(bool, IsClosed, (), (const, override));
MOCK_METHOD(bool, IsUnifiedPlan, (), (const, override));
MOCK_METHOD(bool,
ValidateBundleSettings,
(const cricket::SessionDescription*,
(const std::map<std::string, const cricket::ContentGroup*>&)),
(override));
MOCK_METHOD(absl::optional<std::string>, GetDataMid, (), (const, override));
MOCK_METHOD(RTCErrorOr<rtc::scoped_refptr<RtpTransceiverInterface>>,
AddTransceiver,
(cricket::MediaType,
rtc::scoped_refptr<MediaStreamTrackInterface>,
const RtpTransceiverInit&,
bool),
(override));
MOCK_METHOD(void, StartSctpTransport, (int, int, int), (override));
MOCK_METHOD(void,
AddRemoteCandidate,
(const std::string&, const cricket::Candidate&),
(override));
MOCK_METHOD(Call*, call_ptr, (), (override));
MOCK_METHOD(bool, SrtpRequired, (), (const, override));
MOCK_METHOD(bool,
SetupDataChannelTransport_n,
(const std::string&),
(override));
MOCK_METHOD(void, TeardownDataChannelTransport_n, (), (override));
MOCK_METHOD(void, SetSctpDataMid, (const std::string&), (override));
MOCK_METHOD(void, ResetSctpDataMid, (), (override));
MOCK_METHOD(const FieldTrialsView&, trials, (), (const, override));
// PeerConnectionInternal
MOCK_METHOD(rtc::Thread*, network_thread, (), (const, override));
MOCK_METHOD(rtc::Thread*, worker_thread, (), (const, override));
MOCK_METHOD(bool, initial_offerer, (), (const, override));
MOCK_METHOD(
std::vector<
rtc::scoped_refptr<RtpTransceiverProxyWithInternal<RtpTransceiver>>>,
GetTransceiversInternal,
(),
(const, override));
MOCK_METHOD(sigslot::signal1<SctpDataChannel*>&,
SignalSctpDataChannelCreated,
(),
(override));
MOCK_METHOD(std::vector<DataChannelStats>,
GetDataChannelStats,
(),
(const, override));
MOCK_METHOD(absl::optional<std::string>,
sctp_transport_name,
(),
(const, override));
MOCK_METHOD(cricket::CandidateStatsList,
GetPooledCandidateStats,
(),
(const, override));
MOCK_METHOD((std::map<std::string, cricket::TransportStats>),
GetTransportStatsByNames,
(const std::set<std::string>&),
(override));
MOCK_METHOD(Call::Stats, GetCallStats, (), (override));
MOCK_METHOD(bool,
GetLocalCertificate,
(const std::string&, rtc::scoped_refptr<rtc::RTCCertificate>*),
(override));
MOCK_METHOD(std::unique_ptr<rtc::SSLCertChain>,
GetRemoteSSLCertChain,
(const std::string&),
(override));
MOCK_METHOD(bool, IceRestartPending, (const std::string&), (const, override));
MOCK_METHOD(bool,
GetSslRole,
(const std::string&, rtc::SSLRole*),
(override));
MOCK_METHOD(void, NoteDataAddedEvent, (), (override));
MOCK_METHOD(void,
OnSctpDataChannelClosed,
(DataChannelInterface*),
(override));
};
} // namespace webrtc
#endif // PC_TEST_MOCK_PEER_CONNECTION_INTERNAL_H_