From a3e69e6c74a253c2ff39729c58234d8823ec35c2 Mon Sep 17 00:00:00 2001 From: Rasmus Brandt Date: Tue, 5 Jun 2018 10:55:56 +0200 Subject: [PATCH] Add min_bitrate_bps to RTCRtpEncodingParameters. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is an ObjC followup to https://webrtc-review.googlesource.com/c/src/+/78741. This CL only adds the field to the API, but does not wire it up. Bug: webrtc:9341 Change-Id: Id6b1ac681324120bc90158029da7a80bf99aa512 Reviewed-on: https://webrtc-review.googlesource.com/81182 Reviewed-by: Åsa Persson Reviewed-by: Anders Carlsson Commit-Queue: Rasmus Brandt Cr-Commit-Position: refs/heads/master@{#23524} --- .../Classes/PeerConnection/RTCRtpEncodingParameters.mm | 8 ++++++++ .../Framework/Headers/WebRTC/RTCRtpEncodingParameters.h | 7 +++++++ 2 files changed, 15 insertions(+) diff --git a/sdk/objc/Framework/Classes/PeerConnection/RTCRtpEncodingParameters.mm b/sdk/objc/Framework/Classes/PeerConnection/RTCRtpEncodingParameters.mm index 8e72d18fca..8521862758 100644 --- a/sdk/objc/Framework/Classes/PeerConnection/RTCRtpEncodingParameters.mm +++ b/sdk/objc/Framework/Classes/PeerConnection/RTCRtpEncodingParameters.mm @@ -14,6 +14,7 @@ @synthesize isActive = _isActive; @synthesize maxBitrateBps = _maxBitrateBps; +@synthesize minBitrateBps = _minBitrateBps; @synthesize ssrc = _ssrc; - (instancetype)init { @@ -28,6 +29,10 @@ _maxBitrateBps = [NSNumber numberWithInt:*nativeParameters.max_bitrate_bps]; } + if (nativeParameters.min_bitrate_bps) { + _minBitrateBps = + [NSNumber numberWithInt:*nativeParameters.min_bitrate_bps]; + } if (nativeParameters.ssrc) { _ssrc = [NSNumber numberWithUnsignedLong:*nativeParameters.ssrc]; } @@ -41,6 +46,9 @@ if (_maxBitrateBps != nil) { parameters.max_bitrate_bps = rtc::Optional(_maxBitrateBps.intValue); } + if (_minBitrateBps != nil) { + parameters.min_bitrate_bps = rtc::Optional(_minBitrateBps.intValue); + } if (_ssrc != nil) { parameters.ssrc = rtc::Optional(_ssrc.unsignedLongValue); } diff --git a/sdk/objc/Framework/Headers/WebRTC/RTCRtpEncodingParameters.h b/sdk/objc/Framework/Headers/WebRTC/RTCRtpEncodingParameters.h index a956f0d4c3..5ba0176449 100644 --- a/sdk/objc/Framework/Headers/WebRTC/RTCRtpEncodingParameters.h +++ b/sdk/objc/Framework/Headers/WebRTC/RTCRtpEncodingParameters.h @@ -25,6 +25,13 @@ RTC_EXPORT */ @property(nonatomic, copy, nullable) NSNumber *maxBitrateBps; +/** The minimum bitrate to use for the encoding, or nil if there is no + * limit. + * + * Not implemented. + */ +@property(nonatomic, copy, nullable) NSNumber *minBitrateBps; + /** The SSRC being used by this encoding. */ @property(nonatomic, readonly, nullable) NSNumber *ssrc;