From a3b9b274120db18df1ce5789ba486000b35df970 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sami=20Kalliom=C3=A4ki?= Date: Tue, 25 Sep 2018 15:03:43 +0200 Subject: [PATCH] Also disable AudioDeviceTest constructor for TSAN. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The flaky crash is happening in the constructor. Bug: webrtc:9778 Change-Id: I9ac9a89e033e17de690e594ef263ff83d14fcc5a Reviewed-on: https://webrtc-review.googlesource.com/101880 Reviewed-by: Henrik Andreassson Commit-Queue: Sami Kalliomäki Cr-Commit-Position: refs/heads/master@{#24829} --- modules/audio_device/audio_device_unittest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/audio_device/audio_device_unittest.cc b/modules/audio_device/audio_device_unittest.cc index efa1d993b7..3a5989e482 100644 --- a/modules/audio_device/audio_device_unittest.cc +++ b/modules/audio_device/audio_device_unittest.cc @@ -500,8 +500,9 @@ class AudioDeviceTest : public ::testing::TestWithParam { protected: AudioDeviceTest() : audio_layer_(GetParam()), event_(false, false) { +// TODO(webrtc:9778): Re-enable on THREAD_SANITIZER? #if !defined(ADDRESS_SANITIZER) && !defined(MEMORY_SANITIZER) && \ - !defined(WEBRTC_DUMMY_AUDIO_BUILD) + !defined(WEBRTC_DUMMY_AUDIO_BUILD) && !defined(THREAD_SANITIZER) rtc::LogMessage::LogToDebug(rtc::LS_INFO); // Add extra logging fields here if needed for debugging. rtc::LogMessage::LogTimestamps();