From a31018090e8200b4f4a5cb085e7cf6ec6d349f2e Mon Sep 17 00:00:00 2001 From: Sergey Silkin Date: Tue, 3 Apr 2018 12:15:12 +0200 Subject: [PATCH] Disable H264 videotoolbox unit tests on iOS builds. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The tests fail when running on internal test bots. Bug: webrtc:9099 Change-Id: I89a537fe46ac56891f90e9722055218fd9e87ecf Reviewed-on: https://webrtc-review.googlesource.com/66400 Reviewed-by: Kári Helgason Reviewed-by: Rasmus Brandt Commit-Queue: Sergey Silkin Cr-Commit-Position: refs/heads/master@{#22723} --- .../test/videoprocessor_integrationtest_videotoolbox.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/modules/video_coding/codecs/test/videoprocessor_integrationtest_videotoolbox.cc b/modules/video_coding/codecs/test/videoprocessor_integrationtest_videotoolbox.cc index 165573f684..43647b6d82 100644 --- a/modules/video_coding/codecs/test/videoprocessor_integrationtest_videotoolbox.cc +++ b/modules/video_coding/codecs/test/videoprocessor_integrationtest_videotoolbox.cc @@ -35,12 +35,13 @@ class VideoProcessorIntegrationTestVideoToolbox } }; +// TODO(webrtc:9099): Disabled until the issue is fixed. // HW codecs don't work on simulators. Only run these tests on device. -#if TARGET_OS_IPHONE && !TARGET_IPHONE_SIMULATOR -#define MAYBE_TEST_F TEST_F -#else +// #if TARGET_OS_IPHONE && !TARGET_IPHONE_SIMULATOR +// #define MAYBE_TEST_F TEST_F +// #else #define MAYBE_TEST_F(s, name) TEST_F(s, DISABLED_##name) -#endif +// #endif // TODO(kthelgason): Use RC Thresholds when the internal bitrateAdjuster is no // longer in use.