Comment unused variables in implemented functions 11\n
Bug: webrtc:370878648 Change-Id: Ic31d7744cc8516e4c014bc044fbe2dba9e4d835b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366525 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Dor Hen <dorhen@meta.com> Cr-Commit-Position: refs/heads/main@{#43328}
This commit is contained in:
parent
f5e0f03844
commit
a154b73097
@ -104,13 +104,13 @@ PeerConnectionFactoryInterface::CreatePeerConnection(
|
|||||||
|
|
||||||
RTCErrorOr<rtc::scoped_refptr<PeerConnectionInterface>>
|
RTCErrorOr<rtc::scoped_refptr<PeerConnectionInterface>>
|
||||||
PeerConnectionFactoryInterface::CreatePeerConnectionOrError(
|
PeerConnectionFactoryInterface::CreatePeerConnectionOrError(
|
||||||
const PeerConnectionInterface::RTCConfiguration& configuration,
|
const PeerConnectionInterface::RTCConfiguration& /* configuration */,
|
||||||
PeerConnectionDependencies dependencies) {
|
PeerConnectionDependencies /* dependencies */) {
|
||||||
return RTCError(RTCErrorType::INTERNAL_ERROR);
|
return RTCError(RTCErrorType::INTERNAL_ERROR);
|
||||||
}
|
}
|
||||||
|
|
||||||
RtpCapabilities PeerConnectionFactoryInterface::GetRtpSenderCapabilities(
|
RtpCapabilities PeerConnectionFactoryInterface::GetRtpSenderCapabilities(
|
||||||
cricket::MediaType kind) const {
|
cricket::MediaType /* kind */) const {
|
||||||
return {};
|
return {};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@ -1352,7 +1352,7 @@ class PeerConnectionObserver {
|
|||||||
// RTCSessionDescription" algorithm:
|
// RTCSessionDescription" algorithm:
|
||||||
// https://w3c.github.io/webrtc-pc/#set-description
|
// https://w3c.github.io/webrtc-pc/#set-description
|
||||||
virtual void OnTrack(
|
virtual void OnTrack(
|
||||||
rtc::scoped_refptr<RtpTransceiverInterface> transceiver) {}
|
rtc::scoped_refptr<RtpTransceiverInterface> /* transceiver */) {}
|
||||||
|
|
||||||
// Called when signaling indicates that media will no longer be received on a
|
// Called when signaling indicates that media will no longer be received on a
|
||||||
// track.
|
// track.
|
||||||
@ -1363,7 +1363,7 @@ class PeerConnectionObserver {
|
|||||||
// https://w3c.github.io/webrtc-pc/#process-remote-track-removal
|
// https://w3c.github.io/webrtc-pc/#process-remote-track-removal
|
||||||
// TODO(hbos,deadbeef): Make pure virtual when all subclasses implement it.
|
// TODO(hbos,deadbeef): Make pure virtual when all subclasses implement it.
|
||||||
virtual void OnRemoveTrack(
|
virtual void OnRemoveTrack(
|
||||||
rtc::scoped_refptr<RtpReceiverInterface> receiver) {}
|
rtc::scoped_refptr<RtpReceiverInterface> /* receiver */) {}
|
||||||
|
|
||||||
// Called when an interesting usage is detected by WebRTC.
|
// Called when an interesting usage is detected by WebRTC.
|
||||||
// An appropriate action is to add information about the context of the
|
// An appropriate action is to add information about the context of the
|
||||||
@ -1371,7 +1371,7 @@ class PeerConnectionObserver {
|
|||||||
// log function.
|
// log function.
|
||||||
// The heuristics for defining what constitutes "interesting" are
|
// The heuristics for defining what constitutes "interesting" are
|
||||||
// implementation-defined.
|
// implementation-defined.
|
||||||
virtual void OnInterestingUsage(int usage_pattern) {}
|
virtual void OnInterestingUsage(int /* usage_pattern */) {}
|
||||||
};
|
};
|
||||||
|
|
||||||
// PeerConnectionDependencies holds all of PeerConnections dependencies.
|
// PeerConnectionDependencies holds all of PeerConnections dependencies.
|
||||||
@ -1615,7 +1615,7 @@ class RTC_EXPORT PeerConnectionFactoryInterface
|
|||||||
// StopAecDump function is called.
|
// StopAecDump function is called.
|
||||||
// TODO(webrtc:6463): Delete default implementation when downstream mocks
|
// TODO(webrtc:6463): Delete default implementation when downstream mocks
|
||||||
// classes are updated.
|
// classes are updated.
|
||||||
virtual bool StartAecDump(FILE* file, int64_t max_size_bytes) {
|
virtual bool StartAecDump(FILE* /* file */, int64_t /* max_size_bytes */) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@ -298,7 +298,7 @@ TEST_F(ChannelSendTest, AudioLevelsAttachedToInsertedTransformedFrame) {
|
|||||||
|
|
||||||
std::optional<uint8_t> sent_audio_level;
|
std::optional<uint8_t> sent_audio_level;
|
||||||
auto send_rtp = [&](rtc::ArrayView<const uint8_t> data,
|
auto send_rtp = [&](rtc::ArrayView<const uint8_t> data,
|
||||||
const PacketOptions& options) {
|
const PacketOptions& /* options */) {
|
||||||
RtpPacketReceived packet(&extension_manager);
|
RtpPacketReceived packet(&extension_manager);
|
||||||
packet.Parse(data);
|
packet.Parse(data);
|
||||||
RTPHeader header;
|
RTPHeader header;
|
||||||
|
|||||||
@ -227,8 +227,9 @@ ConvertIceCandidatePairEventType(IceCandidatePairEventType type) {
|
|||||||
|
|
||||||
} // namespace
|
} // namespace
|
||||||
|
|
||||||
std::string RtcEventLogEncoderLegacy::EncodeLogStart(int64_t timestamp_us,
|
std::string RtcEventLogEncoderLegacy::EncodeLogStart(
|
||||||
int64_t utc_time_us) {
|
int64_t timestamp_us,
|
||||||
|
int64_t /* utc_time_us */) {
|
||||||
rtclog::Event rtclog_event;
|
rtclog::Event rtclog_event;
|
||||||
rtclog_event.set_timestamp_us(timestamp_us);
|
rtclog_event.set_timestamp_us(timestamp_us);
|
||||||
rtclog_event.set_type(rtclog::Event::LOG_START);
|
rtclog_event.set_type(rtclog::Event::LOG_START);
|
||||||
|
|||||||
@ -248,8 +248,8 @@ class EventVerifier {
|
|||||||
const LoggedGenericAckReceived& logged_event) const;
|
const LoggedGenericAckReceived& logged_event) const;
|
||||||
|
|
||||||
template <typename EventType, typename ParsedType>
|
template <typename EventType, typename ParsedType>
|
||||||
void VerifyLoggedRtpPacket(const EventType& original_event,
|
void VerifyLoggedRtpPacket(const EventType& /* original_event */,
|
||||||
const ParsedType& logged_event) {
|
const ParsedType& /* logged_event */) {
|
||||||
static_assert(sizeof(ParsedType) == 0,
|
static_assert(sizeof(ParsedType) == 0,
|
||||||
"You have to use one of the two defined template "
|
"You have to use one of the two defined template "
|
||||||
"specializations of VerifyLoggedRtpPacket");
|
"specializations of VerifyLoggedRtpPacket");
|
||||||
|
|||||||
@ -97,9 +97,10 @@ class RtpReceiveChannelHelper : public Base, public MediaChannelUtil {
|
|||||||
std::optional<uint32_t> GetUnsignaledSsrc() const override {
|
std::optional<uint32_t> GetUnsignaledSsrc() const override {
|
||||||
return std::nullopt;
|
return std::nullopt;
|
||||||
}
|
}
|
||||||
void ChooseReceiverReportSsrc(const std::set<uint32_t>& choices) override {}
|
void ChooseReceiverReportSsrc(
|
||||||
|
const std::set<uint32_t>& /* choices */) override {}
|
||||||
|
|
||||||
virtual bool SetLocalSsrc(const StreamParams& sp) { return true; }
|
virtual bool SetLocalSsrc(const StreamParams& /* sp */) { return true; }
|
||||||
void OnDemuxerCriteriaUpdatePending() override {}
|
void OnDemuxerCriteriaUpdatePending() override {}
|
||||||
void OnDemuxerCriteriaUpdateComplete() override {}
|
void OnDemuxerCriteriaUpdateComplete() override {}
|
||||||
|
|
||||||
@ -151,18 +152,19 @@ class RtpReceiveChannelHelper : public Base, public MediaChannelUtil {
|
|||||||
}
|
}
|
||||||
|
|
||||||
void OnRtcpPacketReceived(rtc::CopyOnWriteBuffer* packet,
|
void OnRtcpPacketReceived(rtc::CopyOnWriteBuffer* packet,
|
||||||
int64_t packet_time_us) {
|
int64_t /* packet_time_us */) {
|
||||||
rtcp_packets_.push_back(std::string(packet->cdata<char>(), packet->size()));
|
rtcp_packets_.push_back(std::string(packet->cdata<char>(), packet->size()));
|
||||||
}
|
}
|
||||||
|
|
||||||
void SetFrameDecryptor(uint32_t ssrc,
|
void SetFrameDecryptor(uint32_t /* ssrc */,
|
||||||
rtc::scoped_refptr<webrtc::FrameDecryptorInterface>
|
rtc::scoped_refptr<webrtc::FrameDecryptorInterface>
|
||||||
frame_decryptor) override {}
|
/* frame_decryptor */) override {}
|
||||||
|
|
||||||
void SetDepacketizerToDecoderFrameTransformer(
|
void SetDepacketizerToDecoderFrameTransformer(
|
||||||
uint32_t ssrc,
|
uint32_t /* ssrc */,
|
||||||
rtc::scoped_refptr<webrtc::FrameTransformerInterface> frame_transformer)
|
rtc::scoped_refptr<
|
||||||
override {}
|
webrtc::FrameTransformerInterface> /* frame_transformer */) override {
|
||||||
|
}
|
||||||
|
|
||||||
void SetInterface(MediaChannelNetworkInterface* iface) override {
|
void SetInterface(MediaChannelNetworkInterface* iface) override {
|
||||||
network_interface_ = iface;
|
network_interface_ = iface;
|
||||||
@ -363,18 +365,19 @@ class RtpSendChannelHelper : public Base, public MediaChannelUtil {
|
|||||||
}
|
}
|
||||||
|
|
||||||
void OnRtcpPacketReceived(rtc::CopyOnWriteBuffer* packet,
|
void OnRtcpPacketReceived(rtc::CopyOnWriteBuffer* packet,
|
||||||
int64_t packet_time_us) {
|
int64_t /* packet_time_us */) {
|
||||||
rtcp_packets_.push_back(std::string(packet->cdata<char>(), packet->size()));
|
rtcp_packets_.push_back(std::string(packet->cdata<char>(), packet->size()));
|
||||||
}
|
}
|
||||||
|
|
||||||
// Stuff that deals with encryptors, transformers and the like
|
// Stuff that deals with encryptors, transformers and the like
|
||||||
void SetFrameEncryptor(uint32_t ssrc,
|
void SetFrameEncryptor(uint32_t /* ssrc */,
|
||||||
rtc::scoped_refptr<webrtc::FrameEncryptorInterface>
|
rtc::scoped_refptr<webrtc::FrameEncryptorInterface>
|
||||||
frame_encryptor) override {}
|
/* frame_encryptor */) override {}
|
||||||
void SetEncoderToPacketizerFrameTransformer(
|
void SetEncoderToPacketizerFrameTransformer(
|
||||||
uint32_t ssrc,
|
uint32_t /* ssrc */,
|
||||||
rtc::scoped_refptr<webrtc::FrameTransformerInterface> frame_transformer)
|
rtc::scoped_refptr<
|
||||||
override {}
|
webrtc::FrameTransformerInterface> /* frame_transformer */) override {
|
||||||
|
}
|
||||||
|
|
||||||
void SetInterface(MediaChannelNetworkInterface* iface) override {
|
void SetInterface(MediaChannelNetworkInterface* iface) override {
|
||||||
network_interface_ = iface;
|
network_interface_ = iface;
|
||||||
@ -407,9 +410,9 @@ class RtpSendChannelHelper : public Base, public MediaChannelUtil {
|
|||||||
void set_send_rtcp_parameters(const RtcpParameters& params) {
|
void set_send_rtcp_parameters(const RtcpParameters& params) {
|
||||||
send_rtcp_parameters_ = params;
|
send_rtcp_parameters_ = params;
|
||||||
}
|
}
|
||||||
void OnPacketSent(const rtc::SentPacket& sent_packet) override {}
|
void OnPacketSent(const rtc::SentPacket& /* sent_packet */) override {}
|
||||||
void OnReadyToSend(bool ready) override { ready_to_send_ = ready; }
|
void OnReadyToSend(bool ready) override { ready_to_send_ = ready; }
|
||||||
void OnNetworkRouteChanged(absl::string_view transport_name,
|
void OnNetworkRouteChanged(absl::string_view /* transport_name */,
|
||||||
const rtc::NetworkRoute& network_route) override {
|
const rtc::NetworkRoute& network_route) override {
|
||||||
last_network_route_ = network_route;
|
last_network_route_ = network_route;
|
||||||
++num_network_route_changes_;
|
++num_network_route_changes_;
|
||||||
@ -496,9 +499,9 @@ class FakeVoiceMediaReceiveChannel
|
|||||||
std::unique_ptr<webrtc::AudioSinkInterface> sink) override;
|
std::unique_ptr<webrtc::AudioSinkInterface> sink) override;
|
||||||
|
|
||||||
std::vector<webrtc::RtpSource> GetSources(uint32_t ssrc) const override;
|
std::vector<webrtc::RtpSource> GetSources(uint32_t ssrc) const override;
|
||||||
void SetReceiveNackEnabled(bool enabled) override {}
|
void SetReceiveNackEnabled(bool /* enabled */) override {}
|
||||||
void SetRtcpMode(webrtc::RtcpMode mode) override {}
|
void SetRtcpMode(webrtc::RtcpMode /* mode */) override {}
|
||||||
void SetReceiveNonSenderRttEnabled(bool enabled) override {}
|
void SetReceiveNonSenderRttEnabled(bool /* enabled */) override {}
|
||||||
|
|
||||||
private:
|
private:
|
||||||
class VoiceChannelAudioSink : public AudioSource::Sink {
|
class VoiceChannelAudioSink : public AudioSource::Sink {
|
||||||
@ -574,8 +577,8 @@ class FakeVoiceMediaSendChannel
|
|||||||
|
|
||||||
bool SenderNackEnabled() const override { return false; }
|
bool SenderNackEnabled() const override { return false; }
|
||||||
bool SenderNonSenderRttEnabled() const override { return false; }
|
bool SenderNonSenderRttEnabled() const override { return false; }
|
||||||
void SetReceiveNackEnabled(bool enabled) {}
|
void SetReceiveNackEnabled(bool /* enabled */) {}
|
||||||
void SetReceiveNonSenderRttEnabled(bool enabled) {}
|
void SetReceiveNonSenderRttEnabled(bool /* enabled */) {}
|
||||||
bool SendCodecHasNack() const override { return false; }
|
bool SendCodecHasNack() const override { return false; }
|
||||||
void SetSendCodecChangedCallback(
|
void SetSendCodecChangedCallback(
|
||||||
absl::AnyInvocable<void()> callback) override {}
|
absl::AnyInvocable<void()> callback) override {}
|
||||||
|
|||||||
@ -154,7 +154,9 @@ class FakeNetworkInterface : public MediaChannelNetworkInterface {
|
|||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
virtual int SetOption(SocketType type, rtc::Socket::Option opt, int option) {
|
virtual int SetOption(SocketType /* type */,
|
||||||
|
rtc::Socket::Option opt,
|
||||||
|
int option) {
|
||||||
if (opt == rtc::Socket::OPT_SNDBUF) {
|
if (opt == rtc::Socket::OPT_SNDBUF) {
|
||||||
sendbuf_size_ = option;
|
sendbuf_size_ = option;
|
||||||
} else if (opt == rtc::Socket::OPT_RCVBUF) {
|
} else if (opt == rtc::Socket::OPT_RCVBUF) {
|
||||||
|
|||||||
@ -39,7 +39,7 @@ std::vector<SdpVideoFormat> FakeVideoEncoderFactory::GetSupportedFormats()
|
|||||||
|
|
||||||
std::unique_ptr<VideoEncoder> FakeVideoEncoderFactory::Create(
|
std::unique_ptr<VideoEncoder> FakeVideoEncoderFactory::Create(
|
||||||
const Environment& env,
|
const Environment& env,
|
||||||
const SdpVideoFormat& format) {
|
const SdpVideoFormat& /* format */) {
|
||||||
return std::make_unique<test::FakeEncoder>(env);
|
return std::make_unique<test::FakeEncoder>(env);
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -57,8 +57,8 @@ std::vector<SdpVideoFormat> FakeVideoDecoderFactory::GetSupportedFormats()
|
|||||||
}
|
}
|
||||||
|
|
||||||
std::unique_ptr<VideoDecoder> FakeVideoDecoderFactory::Create(
|
std::unique_ptr<VideoDecoder> FakeVideoDecoderFactory::Create(
|
||||||
const Environment& env,
|
const Environment& /* env */,
|
||||||
const SdpVideoFormat& format) {
|
const SdpVideoFormat& /* format */) {
|
||||||
return std::make_unique<test::FakeDecoder>();
|
return std::make_unique<test::FakeDecoder>();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@ -97,8 +97,8 @@ class FakeAudioSendStream final : public webrtc::AudioSendStream {
|
|||||||
webrtc::SetParametersCallback callback) override;
|
webrtc::SetParametersCallback callback) override;
|
||||||
void Start() override { sending_ = true; }
|
void Start() override { sending_ = true; }
|
||||||
void Stop() override { sending_ = false; }
|
void Stop() override { sending_ = false; }
|
||||||
void SendAudioData(std::unique_ptr<webrtc::AudioFrame> audio_frame) override {
|
void SendAudioData(
|
||||||
}
|
std::unique_ptr<webrtc::AudioFrame> /* audio_frame */) override {}
|
||||||
bool SendTelephoneEvent(int payload_type,
|
bool SendTelephoneEvent(int payload_type,
|
||||||
int payload_frequency,
|
int payload_frequency,
|
||||||
int event,
|
int event,
|
||||||
@ -301,14 +301,16 @@ class FakeVideoReceiveStream final
|
|||||||
void UpdateRtxSsrc(uint32_t ssrc) { config_.rtp.rtx_ssrc = ssrc; }
|
void UpdateRtxSsrc(uint32_t ssrc) { config_.rtp.rtx_ssrc = ssrc; }
|
||||||
|
|
||||||
void SetFrameDecryptor(rtc::scoped_refptr<webrtc::FrameDecryptorInterface>
|
void SetFrameDecryptor(rtc::scoped_refptr<webrtc::FrameDecryptorInterface>
|
||||||
frame_decryptor) override {}
|
/* frame_decryptor */) override {}
|
||||||
|
|
||||||
void SetDepacketizerToDecoderFrameTransformer(
|
void SetDepacketizerToDecoderFrameTransformer(
|
||||||
rtc::scoped_refptr<webrtc::FrameTransformerInterface> frame_transformer)
|
rtc::scoped_refptr<
|
||||||
override {}
|
webrtc::FrameTransformerInterface> /* frame_transformer */) override {
|
||||||
|
}
|
||||||
|
|
||||||
RecordingState SetAndGetRecordingState(RecordingState state,
|
RecordingState SetAndGetRecordingState(
|
||||||
bool generate_key_frame) override {
|
RecordingState /* state */,
|
||||||
|
bool /* generate_key_frame */) override {
|
||||||
return RecordingState();
|
return RecordingState();
|
||||||
}
|
}
|
||||||
void GenerateKeyFrame() override {}
|
void GenerateKeyFrame() override {}
|
||||||
@ -400,14 +402,14 @@ class FakeFlexfecReceiveStream final : public webrtc::FlexfecReceiveStream {
|
|||||||
class FakePayloadTypeSuggester : public webrtc::PayloadTypeSuggester {
|
class FakePayloadTypeSuggester : public webrtc::PayloadTypeSuggester {
|
||||||
public:
|
public:
|
||||||
webrtc::RTCErrorOr<webrtc::PayloadType> SuggestPayloadType(
|
webrtc::RTCErrorOr<webrtc::PayloadType> SuggestPayloadType(
|
||||||
const std::string& mid,
|
const std::string& /* mid */,
|
||||||
cricket::Codec codec) override {
|
cricket::Codec codec) override {
|
||||||
// Ignores mid argument.
|
// Ignores mid argument.
|
||||||
return pt_picker_.SuggestMapping(codec, nullptr);
|
return pt_picker_.SuggestMapping(codec, nullptr);
|
||||||
}
|
}
|
||||||
webrtc::RTCError AddLocalMapping(const std::string& mid,
|
webrtc::RTCError AddLocalMapping(const std::string& /* mid */,
|
||||||
webrtc::PayloadType payload_type,
|
webrtc::PayloadType /* payload_type */,
|
||||||
const cricket::Codec& codec) override {
|
const cricket::Codec& /* codec */) override {
|
||||||
return webrtc::RTCError::OK();
|
return webrtc::RTCError::OK();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@ -58,7 +58,7 @@ FakeWebRtcVideoDecoder::~FakeWebRtcVideoDecoder() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
bool FakeWebRtcVideoDecoder::Configure(const Settings& settings) {
|
bool FakeWebRtcVideoDecoder::Configure(const Settings& /* settings */) {
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -99,7 +99,7 @@ FakeWebRtcVideoDecoderFactory::GetSupportedFormats() const {
|
|||||||
}
|
}
|
||||||
|
|
||||||
std::unique_ptr<webrtc::VideoDecoder> FakeWebRtcVideoDecoderFactory::Create(
|
std::unique_ptr<webrtc::VideoDecoder> FakeWebRtcVideoDecoderFactory::Create(
|
||||||
const webrtc::Environment& env,
|
const webrtc::Environment& /* env */,
|
||||||
const webrtc::SdpVideoFormat& format) {
|
const webrtc::SdpVideoFormat& format) {
|
||||||
if (format.IsCodecInList(supported_codec_formats_)) {
|
if (format.IsCodecInList(supported_codec_formats_)) {
|
||||||
num_created_decoders_++;
|
num_created_decoders_++;
|
||||||
@ -147,13 +147,13 @@ FakeWebRtcVideoEncoder::~FakeWebRtcVideoEncoder() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
void FakeWebRtcVideoEncoder::SetFecControllerOverride(
|
void FakeWebRtcVideoEncoder::SetFecControllerOverride(
|
||||||
webrtc::FecControllerOverride* fec_controller_override) {
|
webrtc::FecControllerOverride* /* fec_controller_override */) {
|
||||||
// Ignored.
|
// Ignored.
|
||||||
}
|
}
|
||||||
|
|
||||||
int32_t FakeWebRtcVideoEncoder::InitEncode(
|
int32_t FakeWebRtcVideoEncoder::InitEncode(
|
||||||
const webrtc::VideoCodec* codecSettings,
|
const webrtc::VideoCodec* codecSettings,
|
||||||
const VideoEncoder::Settings& settings) {
|
const VideoEncoder::Settings& /* settings */) {
|
||||||
webrtc::MutexLock lock(&mutex_);
|
webrtc::MutexLock lock(&mutex_);
|
||||||
codec_settings_ = *codecSettings;
|
codec_settings_ = *codecSettings;
|
||||||
init_encode_event_.Set();
|
init_encode_event_.Set();
|
||||||
@ -161,8 +161,8 @@ int32_t FakeWebRtcVideoEncoder::InitEncode(
|
|||||||
}
|
}
|
||||||
|
|
||||||
int32_t FakeWebRtcVideoEncoder::Encode(
|
int32_t FakeWebRtcVideoEncoder::Encode(
|
||||||
const webrtc::VideoFrame& inputImage,
|
const webrtc::VideoFrame& /* inputImage */,
|
||||||
const std::vector<webrtc::VideoFrameType>* frame_types) {
|
const std::vector<webrtc::VideoFrameType>* /* frame_types */) {
|
||||||
webrtc::MutexLock lock(&mutex_);
|
webrtc::MutexLock lock(&mutex_);
|
||||||
++num_frames_encoded_;
|
++num_frames_encoded_;
|
||||||
init_encode_event_.Set();
|
init_encode_event_.Set();
|
||||||
@ -170,7 +170,7 @@ int32_t FakeWebRtcVideoEncoder::Encode(
|
|||||||
}
|
}
|
||||||
|
|
||||||
int32_t FakeWebRtcVideoEncoder::RegisterEncodeCompleteCallback(
|
int32_t FakeWebRtcVideoEncoder::RegisterEncodeCompleteCallback(
|
||||||
webrtc::EncodedImageCallback* callback) {
|
webrtc::EncodedImageCallback* /* callback */) {
|
||||||
return WEBRTC_VIDEO_CODEC_OK;
|
return WEBRTC_VIDEO_CODEC_OK;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -178,8 +178,8 @@ int32_t FakeWebRtcVideoEncoder::Release() {
|
|||||||
return WEBRTC_VIDEO_CODEC_OK;
|
return WEBRTC_VIDEO_CODEC_OK;
|
||||||
}
|
}
|
||||||
|
|
||||||
void FakeWebRtcVideoEncoder::SetRates(const RateControlParameters& parameters) {
|
void FakeWebRtcVideoEncoder::SetRates(
|
||||||
}
|
const RateControlParameters& /* parameters */) {}
|
||||||
|
|
||||||
webrtc::VideoEncoder::EncoderInfo FakeWebRtcVideoEncoder::GetEncoderInfo()
|
webrtc::VideoEncoder::EncoderInfo FakeWebRtcVideoEncoder::GetEncoderInfo()
|
||||||
const {
|
const {
|
||||||
|
|||||||
@ -707,7 +707,7 @@ EncodedImageCallback::Result SimulcastEncoderAdapter::OnEncodedImage(
|
|||||||
&stream_codec_specific);
|
&stream_codec_specific);
|
||||||
}
|
}
|
||||||
|
|
||||||
void SimulcastEncoderAdapter::OnDroppedFrame(size_t stream_idx) {
|
void SimulcastEncoderAdapter::OnDroppedFrame(size_t /* stream_idx */) {
|
||||||
// Not yet implemented.
|
// Not yet implemented.
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@ -58,13 +58,13 @@ std::unique_ptr<SimulcastTestFixture> CreateSpecificSimulcastTestFixture(
|
|||||||
std::unique_ptr<VideoEncoderFactory> encoder_factory =
|
std::unique_ptr<VideoEncoderFactory> encoder_factory =
|
||||||
std::make_unique<FunctionVideoEncoderFactory>(
|
std::make_unique<FunctionVideoEncoderFactory>(
|
||||||
[internal_encoder_factory](const Environment& env,
|
[internal_encoder_factory](const Environment& env,
|
||||||
const SdpVideoFormat& format) {
|
const SdpVideoFormat& /* format */) {
|
||||||
return std::make_unique<SimulcastEncoderAdapter>(
|
return std::make_unique<SimulcastEncoderAdapter>(
|
||||||
env, internal_encoder_factory, nullptr, SdpVideoFormat::VP8());
|
env, internal_encoder_factory, nullptr, SdpVideoFormat::VP8());
|
||||||
});
|
});
|
||||||
std::unique_ptr<VideoDecoderFactory> decoder_factory =
|
std::unique_ptr<VideoDecoderFactory> decoder_factory =
|
||||||
std::make_unique<FunctionVideoDecoderFactory>(
|
std::make_unique<FunctionVideoDecoderFactory>(
|
||||||
[](const Environment& env, const SdpVideoFormat& format) {
|
[](const Environment& env, const SdpVideoFormat& /* format */) {
|
||||||
return CreateVp8Decoder(env);
|
return CreateVp8Decoder(env);
|
||||||
});
|
});
|
||||||
return CreateSimulcastTestFixture(std::move(encoder_factory),
|
return CreateSimulcastTestFixture(std::move(encoder_factory),
|
||||||
@ -223,7 +223,7 @@ class MockVideoEncoder : public VideoEncoder {
|
|||||||
(override));
|
(override));
|
||||||
|
|
||||||
int32_t InitEncode(const VideoCodec* codecSettings,
|
int32_t InitEncode(const VideoCodec* codecSettings,
|
||||||
const VideoEncoder::Settings& settings) override {
|
const VideoEncoder::Settings& /* settings */) override {
|
||||||
codec_ = *codecSettings;
|
codec_ = *codecSettings;
|
||||||
if (codec_.numberOfSimulcastStreams > 1 && fallback_from_simulcast_) {
|
if (codec_.numberOfSimulcastStreams > 1 && fallback_from_simulcast_) {
|
||||||
return *fallback_from_simulcast_;
|
return *fallback_from_simulcast_;
|
||||||
@ -374,7 +374,7 @@ std::vector<SdpVideoFormat> MockVideoEncoderFactory::GetSupportedFormats()
|
|||||||
}
|
}
|
||||||
|
|
||||||
std::unique_ptr<VideoEncoder> MockVideoEncoderFactory::Create(
|
std::unique_ptr<VideoEncoder> MockVideoEncoderFactory::Create(
|
||||||
const Environment& env,
|
const Environment& /* env */,
|
||||||
const SdpVideoFormat& format) {
|
const SdpVideoFormat& format) {
|
||||||
if (create_video_encoder_return_nullptr_) {
|
if (create_video_encoder_return_nullptr_) {
|
||||||
return nullptr;
|
return nullptr;
|
||||||
@ -480,8 +480,9 @@ class TestSimulcastEncoderAdapterFake : public ::testing::Test,
|
|||||||
SetUp();
|
SetUp();
|
||||||
}
|
}
|
||||||
|
|
||||||
Result OnEncodedImage(const EncodedImage& encoded_image,
|
Result OnEncodedImage(
|
||||||
const CodecSpecificInfo* codec_specific_info) override {
|
const EncodedImage& encoded_image,
|
||||||
|
const CodecSpecificInfo* /* codec_specific_info */) override {
|
||||||
last_encoded_image_width_ = encoded_image._encodedWidth;
|
last_encoded_image_width_ = encoded_image._encodedWidth;
|
||||||
last_encoded_image_height_ = encoded_image._encodedHeight;
|
last_encoded_image_height_ = encoded_image._encodedHeight;
|
||||||
last_encoded_image_simulcast_index_ = encoded_image.SimulcastIndex();
|
last_encoded_image_simulcast_index_ = encoded_image.SimulcastIndex();
|
||||||
@ -1146,7 +1147,7 @@ TEST_F(TestSimulcastEncoderAdapterFake, NativeHandleForwardingOnlyIfSupported) {
|
|||||||
// ...the lowest one gets a software buffer.
|
// ...the lowest one gets a software buffer.
|
||||||
EXPECT_CALL(*encoders[0], Encode)
|
EXPECT_CALL(*encoders[0], Encode)
|
||||||
.WillOnce([&](const VideoFrame& frame,
|
.WillOnce([&](const VideoFrame& frame,
|
||||||
const std::vector<VideoFrameType>* frame_types) {
|
const std::vector<VideoFrameType>* /* frame_types */) {
|
||||||
EXPECT_EQ(frame.video_frame_buffer()->type(),
|
EXPECT_EQ(frame.video_frame_buffer()->type(),
|
||||||
VideoFrameBuffer::Type::kI420);
|
VideoFrameBuffer::Type::kI420);
|
||||||
return 0;
|
return 0;
|
||||||
|
|||||||
@ -288,7 +288,7 @@ webrtc::AudioReceiveStreamInterface::Config BuildReceiveStreamConfig(
|
|||||||
bool use_nack,
|
bool use_nack,
|
||||||
bool enable_non_sender_rtt,
|
bool enable_non_sender_rtt,
|
||||||
const std::vector<std::string>& stream_ids,
|
const std::vector<std::string>& stream_ids,
|
||||||
const std::vector<webrtc::RtpExtension>& extensions,
|
const std::vector<webrtc::RtpExtension>& /* extensions */,
|
||||||
webrtc::Transport* rtcp_send_transport,
|
webrtc::Transport* rtcp_send_transport,
|
||||||
const rtc::scoped_refptr<webrtc::AudioDecoderFactory>& decoder_factory,
|
const rtc::scoped_refptr<webrtc::AudioDecoderFactory>& decoder_factory,
|
||||||
const std::map<int, webrtc::SdpAudioFormat>& decoder_map,
|
const std::map<int, webrtc::SdpAudioFormat>& decoder_map,
|
||||||
|
|||||||
@ -685,7 +685,7 @@ void DcSctpTransport::OnTransportWritableState(
|
|||||||
}
|
}
|
||||||
|
|
||||||
void DcSctpTransport::OnTransportReadPacket(
|
void DcSctpTransport::OnTransportReadPacket(
|
||||||
rtc::PacketTransportInternal* transport,
|
rtc::PacketTransportInternal* /* transport */,
|
||||||
const rtc::ReceivedPacket& packet) {
|
const rtc::ReceivedPacket& packet) {
|
||||||
RTC_DCHECK_RUN_ON(network_thread_);
|
RTC_DCHECK_RUN_ON(network_thread_);
|
||||||
if (packet.decryption_info() != rtc::ReceivedPacket::kDtlsDecrypted) {
|
if (packet.decryption_info() != rtc::ReceivedPacket::kDtlsDecrypted) {
|
||||||
|
|||||||
@ -119,12 +119,13 @@ std::unique_ptr<Packet> AcmSendTestOldApi::NextPacket() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// This method receives the callback from ACM when a new packet is produced.
|
// This method receives the callback from ACM when a new packet is produced.
|
||||||
int32_t AcmSendTestOldApi::SendData(AudioFrameType frame_type,
|
int32_t AcmSendTestOldApi::SendData(
|
||||||
uint8_t payload_type,
|
AudioFrameType frame_type,
|
||||||
uint32_t timestamp,
|
uint8_t payload_type,
|
||||||
const uint8_t* payload_data,
|
uint32_t timestamp,
|
||||||
size_t payload_len_bytes,
|
const uint8_t* payload_data,
|
||||||
int64_t absolute_capture_timestamp_ms) {
|
size_t payload_len_bytes,
|
||||||
|
int64_t /* absolute_capture_timestamp_ms */) {
|
||||||
// Store the packet locally.
|
// Store the packet locally.
|
||||||
frame_type_ = frame_type;
|
frame_type_ = frame_type;
|
||||||
payload_type_ = payload_type;
|
payload_type_ = payload_type;
|
||||||
|
|||||||
@ -114,7 +114,7 @@ class PacketizationCallbackStubOldApi : public AudioPacketizationCallback {
|
|||||||
uint32_t timestamp,
|
uint32_t timestamp,
|
||||||
const uint8_t* payload_data,
|
const uint8_t* payload_data,
|
||||||
size_t payload_len_bytes,
|
size_t payload_len_bytes,
|
||||||
int64_t absolute_capture_timestamp_ms) override {
|
int64_t /* absolute_capture_timestamp_ms */) override {
|
||||||
MutexLock lock(&mutex_);
|
MutexLock lock(&mutex_);
|
||||||
++num_calls_;
|
++num_calls_;
|
||||||
last_frame_type_ = frame_type;
|
last_frame_type_ = frame_type;
|
||||||
@ -1054,14 +1054,14 @@ class AcmSetBitRateTest : public ::testing::Test {
|
|||||||
int channels,
|
int channels,
|
||||||
int payload_type,
|
int payload_type,
|
||||||
int frame_size_samples,
|
int frame_size_samples,
|
||||||
int frame_size_rtp_timestamps) {
|
int /* frame_size_rtp_timestamps */) {
|
||||||
return send_test_->RegisterCodec(payload_name, sampling_freq_hz, channels,
|
return send_test_->RegisterCodec(payload_name, sampling_freq_hz, channels,
|
||||||
payload_type, frame_size_samples);
|
payload_type, frame_size_samples);
|
||||||
}
|
}
|
||||||
|
|
||||||
void RegisterExternalSendCodec(
|
void RegisterExternalSendCodec(
|
||||||
std::unique_ptr<AudioEncoder> external_speech_encoder,
|
std::unique_ptr<AudioEncoder> external_speech_encoder,
|
||||||
int payload_type) {
|
int /* payload_type */) {
|
||||||
send_test_->RegisterExternalCodec(std::move(external_speech_encoder));
|
send_test_->RegisterExternalCodec(std::move(external_speech_encoder));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@ -97,7 +97,7 @@ bool FrameLengthController::Config::FrameLengthChange::operator<(
|
|||||||
}
|
}
|
||||||
|
|
||||||
bool FrameLengthController::FrameLengthIncreasingDecision(
|
bool FrameLengthController::FrameLengthIncreasingDecision(
|
||||||
const AudioEncoderRuntimeConfig& config) {
|
const AudioEncoderRuntimeConfig& /* config */) {
|
||||||
// Increase frame length if
|
// Increase frame length if
|
||||||
// 1. `uplink_bandwidth_bps` is known to be smaller or equal than
|
// 1. `uplink_bandwidth_bps` is known to be smaller or equal than
|
||||||
// `min_encoder_bitrate_bps` plus `prevent_overuse_margin_bps` plus the
|
// `min_encoder_bitrate_bps` plus `prevent_overuse_margin_bps` plus the
|
||||||
@ -153,7 +153,7 @@ bool FrameLengthController::FrameLengthIncreasingDecision(
|
|||||||
}
|
}
|
||||||
|
|
||||||
bool FrameLengthController::FrameLengthDecreasingDecision(
|
bool FrameLengthController::FrameLengthDecreasingDecision(
|
||||||
const AudioEncoderRuntimeConfig& config) {
|
const AudioEncoderRuntimeConfig& /* config */) {
|
||||||
// Decrease frame length if
|
// Decrease frame length if
|
||||||
// 1. shorter frame length is available AND
|
// 1. shorter frame length is available AND
|
||||||
// 2. `uplink_bandwidth_bps` is known to be bigger than
|
// 2. `uplink_bandwidth_bps` is known to be bigger than
|
||||||
|
|||||||
@ -52,7 +52,7 @@ int AudioDecoderPcmU::DecodeInternal(const uint8_t* encoded,
|
|||||||
return static_cast<int>(ret);
|
return static_cast<int>(ret);
|
||||||
}
|
}
|
||||||
|
|
||||||
int AudioDecoderPcmU::PacketDuration(const uint8_t* encoded,
|
int AudioDecoderPcmU::PacketDuration(const uint8_t* /* encoded */,
|
||||||
size_t encoded_len) const {
|
size_t encoded_len) const {
|
||||||
// One encoded byte per sample per channel.
|
// One encoded byte per sample per channel.
|
||||||
return static_cast<int>(encoded_len / Channels());
|
return static_cast<int>(encoded_len / Channels());
|
||||||
@ -98,7 +98,7 @@ int AudioDecoderPcmA::DecodeInternal(const uint8_t* encoded,
|
|||||||
return static_cast<int>(ret);
|
return static_cast<int>(ret);
|
||||||
}
|
}
|
||||||
|
|
||||||
int AudioDecoderPcmA::PacketDuration(const uint8_t* encoded,
|
int AudioDecoderPcmA::PacketDuration(const uint8_t* /* encoded */,
|
||||||
size_t encoded_len) const {
|
size_t encoded_len) const {
|
||||||
// One encoded byte per sample per channel.
|
// One encoded byte per sample per channel.
|
||||||
return static_cast<int>(encoded_len / Channels());
|
return static_cast<int>(encoded_len / Channels());
|
||||||
|
|||||||
@ -57,7 +57,7 @@ std::vector<AudioDecoder::ParseResult> AudioDecoderG722Impl::ParsePayload(
|
|||||||
timestamp, 8, 16);
|
timestamp, 8, 16);
|
||||||
}
|
}
|
||||||
|
|
||||||
int AudioDecoderG722Impl::PacketDuration(const uint8_t* encoded,
|
int AudioDecoderG722Impl::PacketDuration(const uint8_t* /* encoded */,
|
||||||
size_t encoded_len) const {
|
size_t encoded_len) const {
|
||||||
// 1/2 encoded byte per sample per channel.
|
// 1/2 encoded byte per sample per channel.
|
||||||
return static_cast<int>(2 * encoded_len / Channels());
|
return static_cast<int>(2 * encoded_len / Channels());
|
||||||
@ -125,7 +125,7 @@ int AudioDecoderG722StereoImpl::DecodeInternal(const uint8_t* encoded,
|
|||||||
return static_cast<int>(ret);
|
return static_cast<int>(ret);
|
||||||
}
|
}
|
||||||
|
|
||||||
int AudioDecoderG722StereoImpl::PacketDuration(const uint8_t* encoded,
|
int AudioDecoderG722StereoImpl::PacketDuration(const uint8_t* /* encoded */,
|
||||||
size_t encoded_len) const {
|
size_t encoded_len) const {
|
||||||
// 1/2 encoded byte per sample per channel. Make sure the length represents
|
// 1/2 encoded byte per sample per channel. Make sure the length represents
|
||||||
// an equal number of bytes per channel. Otherwise, we cannot de-interleave
|
// an equal number of bytes per channel. Otherwise, we cannot de-interleave
|
||||||
|
|||||||
@ -130,7 +130,7 @@ size_t AudioDecoderOpusImpl::Channels() const {
|
|||||||
}
|
}
|
||||||
|
|
||||||
void AudioDecoderOpusImpl::GeneratePlc(
|
void AudioDecoderOpusImpl::GeneratePlc(
|
||||||
size_t requested_samples_per_channel,
|
size_t /* requested_samples_per_channel */,
|
||||||
rtc::BufferT<int16_t>* concealment_audio) {
|
rtc::BufferT<int16_t>* concealment_audio) {
|
||||||
if (!generate_plc_) {
|
if (!generate_plc_) {
|
||||||
return;
|
return;
|
||||||
|
|||||||
@ -65,7 +65,7 @@ std::unique_ptr<AudioEncoderOpusStates> CreateCodec(
|
|||||||
|
|
||||||
MockAudioNetworkAdaptor** mock_ptr = &states->mock_audio_network_adaptor;
|
MockAudioNetworkAdaptor** mock_ptr = &states->mock_audio_network_adaptor;
|
||||||
AudioEncoderOpusImpl::AudioNetworkAdaptorCreator creator =
|
AudioEncoderOpusImpl::AudioNetworkAdaptorCreator creator =
|
||||||
[mock_ptr](absl::string_view, RtcEventLog* event_log) {
|
[mock_ptr](absl::string_view, RtcEventLog* /* event_log */) {
|
||||||
std::unique_ptr<MockAudioNetworkAdaptor> adaptor(
|
std::unique_ptr<MockAudioNetworkAdaptor> adaptor(
|
||||||
new NiceMock<MockAudioNetworkAdaptor>());
|
new NiceMock<MockAudioNetworkAdaptor>());
|
||||||
EXPECT_CALL(*adaptor, Die());
|
EXPECT_CALL(*adaptor, Die());
|
||||||
|
|||||||
@ -48,8 +48,8 @@ class PowerRatioEstimator : public LappedTransform::Callback {
|
|||||||
protected:
|
protected:
|
||||||
void ProcessAudioBlock(const std::complex<float>* const* input,
|
void ProcessAudioBlock(const std::complex<float>* const* input,
|
||||||
size_t num_input_channels,
|
size_t num_input_channels,
|
||||||
size_t num_freq_bins,
|
size_t /* num_freq_bins */,
|
||||||
size_t num_output_channels,
|
size_t /* num_output_channels */,
|
||||||
std::complex<float>* const* output) override {
|
std::complex<float>* const* output) override {
|
||||||
float low_pow = 0.f;
|
float low_pow = 0.f;
|
||||||
float high_pow = 0.f;
|
float high_pow = 0.f;
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user