admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove LOGGING=1 define.

Browse Source 
The LOGGING define is only used in a single location in our whole codebase:
$ git gs "f LOGGING"
webrtc/base/physicalsocketserver.cc:1584:#if LOGGING
$ git gs "defined(LOGGING"
(no hits)

The above commands also give no hits in Chromium's code base.

BUG=webrtc:6412
NOTRY=True

Review-Url: https://codereview.webrtc.org/2442743002
Cr-Commit-Position: refs/heads/master@{#14799}
This commit is contained in:
kjellander 2016-10-27 02:34:31 -07:00 committed by Commit bot
parent fe90b4176c
commit a101e560b9
3 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
webrtc/base/BUILD.gn
View File

@ -26,10 +26,7 @@ config("rtc_base_approved_all_dependent_config") {
}
config("rtc_base_config") {
defines = [
"FEATURE_ENABLE_SSL",
"LOGGING=1",
]
defines = [ "FEATURE_ENABLE_SSL" ]
}
config("rtc_base_chromium_config") {
@ -350,6 +347,7 @@ rtc_static_library("rtc_base") {
cflags = []
cflags_cc = []
libs = []
defines = []
deps = [
"..:webrtc_common",
]
@ -368,7 +366,6 @@ rtc_static_library("rtc_base") {
]
all_dependent_configs = [ ":rtc_base_all_dependent_config" ]
defines = [ "LOGGING=1" ]
sources = [
"applefilesystem.mm",

1
webrtc/base/base.gyp
View File

@ -232,7 +232,6 @@
'FEATURE_ENABLE_SSL',
'SSL_USE_OPENSSL',
'HAVE_OPENSSL_SSL_H',
'LOGGING=1',
],
'sources': [
'applefilesystem.mm',

3
webrtc/base/physicalsocketserver.cc
View File

@ -1580,8 +1580,6 @@ bool PhysicalSocketServer::Wait(int cmsWait, bool process_io) {
WSANETWORKEVENTS wsaEvents;
int err = WSAEnumNetworkEvents(s, events[0], &wsaEvents);
if (err == 0) {
#if LOGGING
{
if ((wsaEvents.lNetworkEvents & FD_READ) &&
wsaEvents.iErrorCode[FD_READ_BIT] != 0) {
@ -1609,7 +1607,6 @@ bool PhysicalSocketServer::Wait(int cmsWait, bool process_io) {
<< wsaEvents.iErrorCode[FD_CLOSE_BIT];
}
}
#endif
uint32_t ff = 0;
int errcode = 0;
if (wsaEvents.lNetworkEvents & FD_READ)