admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removing SetTransportOverhead from SSCC Interface.

Browse Source 
This is a follow up on an earlier CL removing the usage of
SetTransportOverhead.

Bug: webrtc:8415
Change-Id: I8d9572c06f3ae1e8cacbe7b9bd57a9b65f371c0e
Reviewed-on: https://webrtc-review.googlesource.com/61502
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22427}
This commit is contained in:
Sebastian Jansson 2018-03-13 16:16:51 +01:00 committed by Commit Bot
parent ebd01e8660
commit a03585f611
4 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/congestion_controller/include/send_side_congestion_controller.h
View File

@ -80,8 +80,8 @@ class SendSideCongestionController
void SignalNetworkState(NetworkState state) override;
// Deprecated: Is updated by OnNetworkRouteChanged
RTC_DEPRECATED void SetTransportOverhead(
size_t transport_overhead_bytes_per_packet) override;
RTC_DEPRECATED virtual void SetTransportOverhead(
size_t transport_overhead_bytes_per_packet);
// Deprecated: Use GetBandwidthObserver instead.
RTC_DEPRECATED virtual BitrateController* GetBitrateController() const;

2
modules/congestion_controller/include/send_side_congestion_controller_interface.h
View File

@ -57,8 +57,6 @@ class SendSideCongestionControllerInterface : public CallStatsObserver,
int min_bitrate_bps,
int max_bitrate_bps) = 0;
virtual void SignalNetworkState(NetworkState state) = 0;
virtual void SetTransportOverhead(
size_t transport_overhead_bytes_per_packet) = 0;
virtual RtcpBandwidthObserver* GetBandwidthObserver() = 0;
virtual bool AvailableBandwidth(uint32_t* bandwidth) const = 0;
virtual TransportFeedbackObserver* GetTransportFeedbackObserver() = 0;

2
modules/congestion_controller/rtp/include/send_side_congestion_controller.h
View File

@ -93,8 +93,6 @@ class SendSideCongestionController
int min_bitrate_bps,
int max_bitrate_bps) override;
void SignalNetworkState(NetworkState state) override;
void SetTransportOverhead(
size_t transport_overhead_bytes_per_packet) override;
RtcpBandwidthObserver* GetBandwidthObserver() override;

6
modules/congestion_controller/rtp/send_side_congestion_controller.cc
View File

@ -461,12 +461,6 @@ void SendSideCongestionController::SignalNetworkState(NetworkState state) {
});
}
void SendSideCongestionController::SetTransportOverhead(
size_t transport_overhead_bytes_per_packet) {
// TODO(srte): Remove this method from SendSideCongestionControllerInterface
RTC_NOTREACHED();
}
void SendSideCongestionController::OnSentPacket(
const rtc::SentPacket& sent_packet) {
// We're not interested in packets without an id, which may be stun packets,