admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete NullWebrtcVideoEngine as unused

Browse Source 
Bug: webrtc:15574
Change-Id: Ieec9ad40d28ae842b212d65aaec039238d39a497
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347560
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42070}
This commit is contained in:
Danil Chapovalov 2024-04-15 16:44:31 +02:00 committed by WebRTC LUCI CQ
parent 8f16289e10
commit a01300a684
3 changed files with 0 additions and 103 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
media/BUILD.gn
View File

@ -671,7 +671,6 @@ rtc_library("rtc_audio_video") {
sources = [ sources = [
"engine/adm_helpers.cc", "engine/adm_helpers.cc",
"engine/adm_helpers.h", "engine/adm_helpers.h",
"engine/null_webrtc_video_engine.h",
"engine/payload_type_mapper.cc", "engine/payload_type_mapper.cc",
"engine/payload_type_mapper.h", "engine/payload_type_mapper.h",
"engine/webrtc_media_engine.cc", "engine/webrtc_media_engine.cc",
@ -1017,7 +1016,6 @@ if (rtc_include_tests) {
"base/video_common_unittest.cc", "base/video_common_unittest.cc",
"engine/internal_decoder_factory_unittest.cc", "engine/internal_decoder_factory_unittest.cc",
"engine/internal_encoder_factory_unittest.cc", "engine/internal_encoder_factory_unittest.cc",
"engine/null_webrtc_video_engine_unittest.cc",
"engine/payload_type_mapper_unittest.cc", "engine/payload_type_mapper_unittest.cc",
"engine/simulcast_encoder_adapter_unittest.cc", "engine/simulcast_encoder_adapter_unittest.cc",
"engine/webrtc_media_engine_unittest.cc", "engine/webrtc_media_engine_unittest.cc",

54
media/engine/null_webrtc_video_engine.h
View File

@ -1,54 +0,0 @@
/*
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#ifndef MEDIA_ENGINE_NULL_WEBRTC_VIDEO_ENGINE_H_
#define MEDIA_ENGINE_NULL_WEBRTC_VIDEO_ENGINE_H_
#include <vector>
#include "media/base/media_channel.h"
#include "media/base/media_engine.h"
namespace webrtc {
class Call;
} // namespace webrtc
namespace cricket {
// Video engine implementation that does nothing and can be used in
// CompositeMediaEngine.
class NullWebRtcVideoEngine : public VideoEngineInterface {
public:
std::vector<VideoCodec> send_codecs(bool) const override {
return std::vector<VideoCodec>();
}
std::vector<VideoCodec> recv_codecs(bool) const override {
return std::vector<VideoCodec>();
}
std::vector<VideoCodec> send_codecs() const override {
return std::vector<VideoCodec>();
}
std::vector<VideoCodec> recv_codecs() const override {
return std::vector<VideoCodec>();
}
std::vector<webrtc::RtpHeaderExtensionCapability> GetRtpHeaderExtensions()
const override {
return {};
}
};
} // namespace cricket
#endif // MEDIA_ENGINE_NULL_WEBRTC_VIDEO_ENGINE_H_

47
media/engine/null_webrtc_video_engine_unittest.cc
View File

@ -1,47 +0,0 @@
/*
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "media/engine/null_webrtc_video_engine.h"
#include <memory>
#include <utility>
#include "api/task_queue/default_task_queue_factory.h"
#include "api/task_queue/task_queue_factory.h"
#include "api/transport/field_trial_based_config.h"
#include "media/engine/webrtc_voice_engine.h"
#include "modules/audio_device/include/mock_audio_device.h"
#include "modules/audio_processing/include/audio_processing.h"
#include "test/gtest.h"
#include "test/mock_audio_decoder_factory.h"
#include "test/mock_audio_encoder_factory.h"
namespace cricket {
// Simple test to check if NullWebRtcVideoEngine implements the methods
// required by CompositeMediaEngine.
TEST(NullWebRtcVideoEngineTest, CheckInterface) {
std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory =
webrtc::CreateDefaultTaskQueueFactory();
rtc::scoped_refptr<webrtc::test::MockAudioDeviceModule> adm =
webrtc::test::MockAudioDeviceModule::CreateNice();
webrtc::FieldTrialBasedConfig trials;
auto audio_engine = std::make_unique<WebRtcVoiceEngine>(
task_queue_factory.get(), adm.get(),
webrtc::MockAudioEncoderFactory::CreateUnusedFactory(),
webrtc::MockAudioDecoderFactory::CreateUnusedFactory(), nullptr,
webrtc::AudioProcessingBuilder().Create(), nullptr, trials);
CompositeMediaEngine engine(std::move(audio_engine),
std::make_unique<NullWebRtcVideoEngine>());
engine.Init();
}
} // namespace cricket