admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add RTC_DCHECK_IS_ON to unittest, as death is expected with DCHECK

Browse Source 
The problem is that in some opt builds we remove RTC_DCHECK, and hence the test that expects death through RTC_DCHECK fails. Adding RTC_DCHECK_IS_ON ensures that test is coupled with builds that include RTC_DCHECK.

Bug: webrtc:358039777
Change-Id: I7721849dc76ce976ac4a084273cedad44f96fef2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366524
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43386}
This commit is contained in:
Liad Rubin 2024-10-27 12:16:50 +02:00 committed by WebRTC LUCI CQ
parent 71ba9cbb80
commit 9fb71e3b01
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common_video/corruption_detection_converters_unittest.cc
View File

@ -153,7 +153,7 @@ TEST(FrameInstrumentationSyncDataToCorruptionDetectionMessageTest,
EXPECT_TRUE(message->interpret_sequence_index_as_most_significant_bits()); EXPECT_TRUE(message->interpret_sequence_index_as_most_significant_bits());
} }
#if GTEST_HAS_DEATH_TEST #if GTEST_HAS_DEATH_TEST && RTC_DCHECK_IS_ON
TEST(FrameInstrumentationSyncDataToCorruptionDetectionMessageTest, TEST(FrameInstrumentationSyncDataToCorruptionDetectionMessageTest,
FailsWhenSetToNotCommunicateUpperBits) { FailsWhenSetToNotCommunicateUpperBits) {
FrameInstrumentationSyncData data = {.sequence_index = 1, FrameInstrumentationSyncData data = {.sequence_index = 1,