admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Skip tests failing with the new version of UBSan.

Browse Source 
Bug: webrtc:345525069, webrtc:345674542
Change-Id: I031adfe33ed4057dcd79cc9fb431838f14b315dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/353902
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42447}
This commit is contained in:
Mirko Bonadei 2024-06-07 10:03:36 +00:00 committed by WebRTC LUCI CQ
parent c74412b304
commit 9f6bb625e6
3 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/audio_coding/codecs/builtin_audio_encoder_factory_unittest.cc
View File

@ -57,6 +57,12 @@ TEST_P(AudioEncoderFactoryTest, CanRunAllSupportedEncoders) {
auto factory = GetParam(); auto factory = GetParam();
auto supported_encoders = factory->GetSupportedEncoders(); auto supported_encoders = factory->GetSupportedEncoders();
for (const auto& spec : supported_encoders) { for (const auto& spec : supported_encoders) {
// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove G722.
#if defined(__has_feature) && __has_feature(undefined_behavior_sanitizer)
if (spec.format.name == "G722") {
GTEST_SKIP() << "Skipping G722, see webrtc:345525069.";
}
#endif
auto encoder = auto encoder =
factory->MakeAudioEncoder(kTestPayloadType, spec.format, absl::nullopt); factory->MakeAudioEncoder(kTestPayloadType, spec.format, absl::nullopt);
EXPECT_TRUE(encoder); EXPECT_TRUE(encoder);

5
modules/audio_coding/codecs/ilbc/ilbc_unittest.cc
View File

@ -15,7 +15,12 @@
namespace webrtc { namespace webrtc {
// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove iLBC.
#if defined(__has_feature) && __has_feature(undefined_behavior_sanitizer)
TEST(IlbcTest, DISABLED_BadPacket) {
#else
TEST(IlbcTest, BadPacket) { TEST(IlbcTest, BadPacket) {
#endif
// Get a good packet. // Get a good packet.
AudioEncoderIlbcConfig config; AudioEncoderIlbcConfig config;
config.frame_size_ms = 20; // We need 20 ms rather than the default 30 ms; config.frame_size_ms = 20; // We need 20 ms rather than the default 30 ms;

10
modules/audio_processing/test/debug_dump_test.cc
View File

@ -293,7 +293,12 @@ TEST_F(DebugDumpTest, SimpleCase) {
VerifyDebugDump(generator.dump_file_name()); VerifyDebugDump(generator.dump_file_name());
} }
// TODO(bugs.webrtc.org/345674542): Fix/enable.
#if defined(__has_feature) && __has_feature(undefined_behavior_sanitizer)
TEST_F(DebugDumpTest, DISABLED_ChangeInputFormat) {
#else
TEST_F(DebugDumpTest, ChangeInputFormat) { TEST_F(DebugDumpTest, ChangeInputFormat) {
#endif
DebugDumpGenerator generator(/*apm_config=*/{}); DebugDumpGenerator generator(/*apm_config=*/{});
generator.StartRecording(); generator.StartRecording();
@ -310,7 +315,12 @@ TEST_F(DebugDumpTest, ChangeInputFormat) {
VerifyDebugDump(generator.dump_file_name()); VerifyDebugDump(generator.dump_file_name());
} }
// TODO(bugs.webrtc.org/345674542): Fix/enable.
#if defined(__has_feature) && __has_feature(undefined_behavior_sanitizer)
TEST_F(DebugDumpTest, DISABLED_ChangeReverseFormat) {
#else
TEST_F(DebugDumpTest, ChangeReverseFormat) { TEST_F(DebugDumpTest, ChangeReverseFormat) {
#endif
DebugDumpGenerator generator(/*apm_config=*/{}); DebugDumpGenerator generator(/*apm_config=*/{});
generator.StartRecording(); generator.StartRecording();
generator.Process(100); generator.Process(100);