From 9f57404334d1d0fc570e7f8fac48e6278ae0a0af Mon Sep 17 00:00:00 2001 From: "kjellander@webrtc.org" Date: Mon, 7 Apr 2014 08:01:06 +0000 Subject: [PATCH] Excluding and suppressing Dr Memory test failures. With these tests excluded and failures suppressed we should be able to bring Dr Memory Full into a green state in http://build.chromium.org/p/client.webrtc.fyi/waterfall so we can move the bots into the main waterfall. BUG=3158, 3159 TEST=Ran successful runs of the tests that never completed using the reproduction steps in the issues listed above on a local Windows box. The tests that just failed weren't tried, since they cannot have been blocking other possibly failing tests in the same binary. R=pbos@webrtc.org TBR=pbos Review URL: https://webrtc-codereview.appspot.com/11209004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@5850 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../valgrind-webrtc/drmemory/suppressions.txt | 90 +++++++++++++++++++ ...le_media_unittest.gtest-drmemory_win32.txt | 3 + ...ngle_p2p_unittest.gtest-drmemory_win32.txt | 3 + ...nnection_unittest.gtest-drmemory_win32.txt | 3 + ...modules_unittests.gtest-drmemory_win32.txt | 1 + ...ideo_engine_tests.gtest-drmemory_win32.txt | 3 + 6 files changed, 103 insertions(+) create mode 100644 tools/valgrind-webrtc/gtest_exclude/libjingle_media_unittest.gtest-drmemory_win32.txt create mode 100644 tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-drmemory_win32.txt create mode 100644 tools/valgrind-webrtc/gtest_exclude/libjingle_peerconnection_unittest.gtest-drmemory_win32.txt create mode 100644 tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt diff --git a/tools/valgrind-webrtc/drmemory/suppressions.txt b/tools/valgrind-webrtc/drmemory/suppressions.txt index 98ddd5381e..2a8a2dd7b9 100644 --- a/tools/valgrind-webrtc/drmemory/suppressions.txt +++ b/tools/valgrind-webrtc/drmemory/suppressions.txt @@ -74,3 +74,93 @@ system call NtUserGetThreadDesktop parameter value #1 *!webrtc::ScreenCapturer::Create *!webrtc::ScreenCapturerTest::SetUp *!testing::internal::HandleSehExceptionsInMethodIfSupported + +# libjingle_media_unittest fails on Win DrMemory Full +UNINITIALIZED READ +name=https://code.google.com/p/webrtc/issues/detail?id=3158 (1) +*!_output_l +*!_vsnprintf_l +*!_vsnprintf +*!webrtc::Trace::Add +*!webrtc::ViECodecImpl::GetCodecTargetBitrate +*!cricket::WebRtcVideoMediaChannel::MaybeChangeStartBitrate +*!cricket::WebRtcVideoMediaChannel::SetSendCodec +*!cricket::WebRtcVideoMediaChannel::SetSendCodec +*!cricket::WebRtcVideoMediaChannel::SetSendCodecs +*!VideoMediaChannelTest<>::SetOneCodec +*!VideoMediaChannelTest<>::Send +*!VideoMediaChannelTest<>::TwoStreamsSendAndFailUnsignalledRecv +*!WebRtcVideoMediaChannelTest_TwoStreamsSendAndFailUnsignalledRecv_Test::TestBody +*!testing::internal::HandleSehExceptionsInMethodIfSupported<> + +UNINITIALIZED READ +name=https://code.google.com/p/webrtc/issues/detail?id=3158 (2) +*!_output_l +*!_vsnprintf_l +*!_vsnprintf +*!webrtc::Trace::Add +*!webrtc::ViECodecImpl::GetCodecTargetBitrate +*!cricket::WebRtcVideoMediaChannel::MaybeChangeStartBitrate +*!cricket::WebRtcVideoMediaChannel::MaybeResetVieSendCodec +*!cricket::WebRtcVideoMediaChannel::SendFrame +*!cricket::WebRtcVideoMediaChannel::SendFrame +*!sigslot::_connection2<>::emit +*!sigslot::signal2<>::operator() +*!cricket::VideoCapturer::OnFrameCaptured +*!sigslot::_connection2<>::emit +*!sigslot::signal2<>::operator() +*!cricket::FakeVideoCapturer::CaptureCustomFrame +*!cricket::FakeVideoCapturer::CaptureFrame +*!VideoMediaChannelTest<>::SendFrame +*!VideoMediaChannelTest<>::Send +*!VideoMediaChannelTest<>::TwoStreamsSendAndFailUnsignalledRecv +*!WebRtcVideoMediaChannelTest_TwoStreamsSendAndFailUnsignalledRecv_Test::TestBody +*!testing::internal::HandleSehExceptionsInMethodIfSupported<> + +UNINITIALIZED READ +name=https://code.google.com/p/webrtc/issues/detail?id=3158 (3) +*!_output_l +*!_vsnprintf_l +*!_vsnprintf +*!webrtc::Trace::Add +*!webrtc::ViEEncoder::DeliverFrame +*!webrtc::ViEFrameProviderBase::DeliverFrame +*!webrtc::ViECapturer::DeliverI420Frame +*!webrtc::ViECapturer::ViECaptureProcess +*!webrtc::ViECapturer::ViECaptureThreadFunction +*!webrtc::ThreadWindows::Run +*!webrtc::ThreadWindows::StartThread +*!_callthreadstartex +*!_threadstartex +KERNEL32.dll!BaseThreadInitThunk + +# libjingle_unittest, fails on Win DrMemory Full +UNINITIALIZED READ +name=https://code.google.com/p/webrtc/issues/detail?id=3158 (4) +*!_towlower_l +*!towlower +*!tolowercase +*!talk_base::IsDefaultBrowserFirefox +*!talk_base::GetProxySettingsForUrl +*!talk_base::AutoDetectProxy::GetProxyForUrl +*!talk_base::AutoDetectProxy::DoWork +*!talk_base::SignalThread::Run +*!talk_base::SignalThread::Worker::Run +*!talk_base::Thread::PreRun +KERNEL32.dll!BaseThreadInitThunk + +UNINITIALIZED READ +name=https://code.google.com/p/webrtc/issues/detail?id=3158 (5) +drmemorylib.dll!replace_memcmp +*!TestConnectivity +*!TestPhysicalInternal +*!NatTest_TestPhysicalIPv6_Test::TestBody +*!testing::internal::HandleSehExceptionsInMethodIfSupported<> + +UNINITIALIZED READ +name=https://code.google.com/p/webrtc/issues/detail?id=3158 (6) +*!TestConnectivity +*!TestPhysicalInternal +*!NatTest_TestPhysicalIPv6_Test::TestBody +*!testing::internal::HandleSehExceptionsInMethodIfSupported<> + diff --git a/tools/valgrind-webrtc/gtest_exclude/libjingle_media_unittest.gtest-drmemory_win32.txt b/tools/valgrind-webrtc/gtest_exclude/libjingle_media_unittest.gtest-drmemory_win32.txt new file mode 100644 index 0000000000..ab83872932 --- /dev/null +++ b/tools/valgrind-webrtc/gtest_exclude/libjingle_media_unittest.gtest-drmemory_win32.txt @@ -0,0 +1,3 @@ +# Fails on Dr Memory Full. +# https://code.google.com/p/webrtc/issues/detail?id=3158 +WebRtcVideoMediaChannelTest.SendVp8HdAndReceiveAdaptedVp8Vga diff --git a/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-drmemory_win32.txt b/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-drmemory_win32.txt new file mode 100644 index 0000000000..c879a244fb --- /dev/null +++ b/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-drmemory_win32.txt @@ -0,0 +1,3 @@ +# Fails on Dr Memory Full. +# https://code.google.com/p/webrtc/issues/detail?id=3158 +P2PTransportChannelTest.TestOPENToOPENAsGiceNoneSharedUfrag diff --git a/tools/valgrind-webrtc/gtest_exclude/libjingle_peerconnection_unittest.gtest-drmemory_win32.txt b/tools/valgrind-webrtc/gtest_exclude/libjingle_peerconnection_unittest.gtest-drmemory_win32.txt new file mode 100644 index 0000000000..38ef1c2efd --- /dev/null +++ b/tools/valgrind-webrtc/gtest_exclude/libjingle_peerconnection_unittest.gtest-drmemory_win32.txt @@ -0,0 +1,3 @@ +# Flakily fails on Dr Memory Light/Full. +# https://code.google.com/p/webrtc/issues/detail?id=3158 +JsepPeerConnectionP2PTestClient.LocalP2PTest16To9 diff --git a/tools/valgrind-webrtc/gtest_exclude/modules_unittests.gtest-drmemory_win32.txt b/tools/valgrind-webrtc/gtest_exclude/modules_unittests.gtest-drmemory_win32.txt index 2ec937b307..8cab2f6581 100644 --- a/tools/valgrind-webrtc/gtest_exclude/modules_unittests.gtest-drmemory_win32.txt +++ b/tools/valgrind-webrtc/gtest_exclude/modules_unittests.gtest-drmemory_win32.txt @@ -1,4 +1,5 @@ # Too slow to run with Dr Memory on Windows. +ApmTest.EchoCancellationReportsCorrectDelays VideoProcessingModuleTest.Denoising diff --git a/tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt b/tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt new file mode 100644 index 0000000000..df482cacc2 --- /dev/null +++ b/tools/valgrind-webrtc/gtest_exclude/video_engine_tests.gtest-drmemory_win32.txt @@ -0,0 +1,3 @@ +# Never completes on Dr Memory Full. +# https://code.google.com/p/webrtc/issues/detail?id=3159 +CallTest.SendsAndReceivesMultipleStreams