From 9f3ea9d93450dc55627b5af0517c82e60beb7c5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Bostr=C3=B6m?= Date: Thu, 3 Aug 2023 13:39:06 +0200 Subject: [PATCH] Increase concealement threshold for debug bots. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Internal bots are flaking, 0.96666666666666667 concealement observed. Bug: b/294020344 Change-Id: I65ff8d1dcfe52ba4c8024736cf203005d5c1e4f0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314541 Commit-Queue: Henrik Boström Reviewed-by: Harald Alvestrand Reviewed-by: Christoffer Jansson Cr-Commit-Position: refs/heads/main@{#40508} --- pc/test/integration_test_helpers.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pc/test/integration_test_helpers.h b/pc/test/integration_test_helpers.h index 24491e1a9d..889161e797 100644 --- a/pc/test/integration_test_helpers.h +++ b/pc/test/integration_test_helpers.h @@ -706,9 +706,13 @@ class PeerConnectionIntegrationWrapper : public webrtc::PeerConnectionObserver, // Worst bots: // Nondebug: Linux32 Release at conceal rate 0.606597 (CI run) // Debug: linux_x86_dbg bot at conceal rate 0.854 + // internal bot at conceal rate 0.967 (b/294020344) + // TODO(https://crbug.com/webrtc/15393): Improve audio quality during + // renegotiation so that we can reduce these thresholds, 99% is not even + // close to the 20% deemed unacceptable above or the 0% that would be ideal. if (delta_samples > 0) { #if !defined(NDEBUG) - EXPECT_LT(1.0 * delta_concealed / delta_samples, 0.95) + EXPECT_LT(1.0 * delta_concealed / delta_samples, 0.99) << "Concealed " << delta_concealed << " of " << delta_samples << " samples"; #else