admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Set LoggedIceCandidatePairEvent.transaction_id to default value if missing.

Browse Source 
Bug: webrtc:9972
Change-Id: I559ccb6799b494a9013523d3960a725ea7fd448e
Reviewed-on: https://webrtc-review.googlesource.com/c/114240
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Zach Stein <zstein@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26006}
This commit is contained in:
Zach Stein 2018-12-12 15:09:40 -08:00 committed by Commit Bot
parent 3e94557b04
commit 9e2e6e704b
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
logging/rtc_event_log/rtc_event_log_parser_new.cc
View File

@ -1741,6 +1741,8 @@ LoggedIceCandidatePairEvent ParsedRtcEventLogNew::GetIceCandidatePairEvent(
res.type = GetRuntimeIceCandidatePairEventType(event.event_type());
RTC_CHECK(event.has_candidate_pair_id());
res.candidate_pair_id = event.candidate_pair_id();
// transaction_id is not supported by rtclog::Event
res.transaction_id = 0;
return res;
}
@ -2420,8 +2422,8 @@ void ParsedRtcEventLogNew::StoreIceCandidateEvent(
ice_event.candidate_pair_id = proto.candidate_pair_id();
// TODO(zstein): Make the transaction_id field required once all old versions
// of the log (which don't have the field) are obsolete.
if (proto.has_transaction_id())
ice_event.transaction_id = proto.transaction_id();
ice_event.transaction_id =
proto.has_transaction_id() ? proto.transaction_id() : 0;
ice_candidate_pair_events_.push_back(ice_event);