admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent TimeUntilNextProcess log spam.

Browse Source 
Negative values from TimeUntilNextProcess indicate that the module
wanted to run sooner than possible, not that an invalid error code was
returned. As such it's not a contract error.

BUG=webrtc:4879
NOTRY=true

Review URL: https://codereview.webrtc.org/1257833004

Cr-Commit-Position: refs/heads/master@{#9740}
This commit is contained in:
pbos 2015-08-20 01:23:48 -07:00 committed by Commit bot
parent d476b95504
commit 9e260f184b
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
webrtc/modules/utility/source/process_thread_impl.cc
View File

@ -25,12 +25,9 @@ const int64_t kCallProcessImmediately = -1;
int64_t GetNextCallbackTime(Module* module, int64_t time_now) {
int64_t interval = module->TimeUntilNextProcess();
// Currently some implementations erroneously return error codes from
// TimeUntilNextProcess(). So, as is, we correct that and log an error.
if (interval < 0) {
LOG(LS_ERROR) << "TimeUntilNextProcess returned an invalid value "
<< interval;
interval = 0;
// Falling behind, we should call the callback now.
return time_now;
}
return time_now + interval;
}