From 9d9c3f4544e55b7dc7b21c58834ac80c3e3827f5 Mon Sep 17 00:00:00 2001
From: Beining Chen <beining@google.com>
Date: Wed, 7 Jun 2023 02:30:41 +0000
Subject: [PATCH] [Analysis] Remove old threshold fields

The luci-analysis system now uses the new threhold schema for bug filing. Remove old fields as they are no longer used anywhere.

Bug: None
Change-Id: Iaa8e7d62ff12fb7e16563c762296efa559e72a92
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/308060
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Beining Chen <beining@google.com>
Cr-Commit-Position: refs/heads/main@{#40241}
---
 infra/config/luci-analysis.cfg | 43 +---------------------------------
 1 file changed, 1 insertion(+), 42 deletions(-)

diff --git a/infra/config/luci-analysis.cfg b/infra/config/luci-analysis.cfg
index fa6dc4fb55..3a08bae367 100644
--- a/infra/config/luci-analysis.cfg
+++ b/infra/config/luci-analysis.cfg
@@ -1,18 +1,6 @@
 # Schema for this config file: ProjectConfig in:
 # https://luci-config.appspot.com/schemas/projects:luci-analysis.cfg
-bug_filing_threshold {
-  presubmit_runs_failed {
-    # clusters blocking developers should have bugs filed.
-    one_day: 3
-  }
-  test_runs_failed {
-    # clusters that aren't blocking developers but are failing a significant
-    # amount of tasks should have bugs filed to look into optimizing machine
-    # resource usage.
-    one_day: 500
-  }
-}
-# TODO(beining): WIP. This is going to replace bug_filling_threshold.
+
 bug_filing_thresholds {
   metric_id: "human-cls-failed-presubmit"
   threshold {
@@ -52,12 +40,6 @@ monorail {
   priority_field_id: 36
   priorities {
     priority: "0"
-    threshold {
-      presubmit_runs_failed {
-        one_day: 20
-      }
-    }
-    # TODO(beining): WIP. This is going to replace threshold.
     thresholds {
       metric_id: "human-cls-failed-presubmit"
       threshold {
@@ -67,12 +49,6 @@ monorail {
   }
   priorities {
     priority: "1"
-    threshold {
-      presubmit_runs_failed {
-        one_day: 10
-      }
-    }
-    # TODO(beining): WIP. This is going to replace threshold.
     thresholds {
       metric_id: "human-cls-failed-presubmit"
       threshold {
@@ -82,12 +58,6 @@ monorail {
   }
   priorities {
     priority: "2"
-    threshold {
-      presubmit_runs_failed {
-        one_day: 2
-      }
-    }
-    # TODO(beining): WIP. This is going to replace threshold.
     thresholds {
       metric_id: "human-cls-failed-presubmit"
       threshold {
@@ -97,17 +67,6 @@ monorail {
   }
   priorities {
     priority: "3"
-    threshold {
-      # Clusters which fail to meet this threshold will be closed.
-      test_runs_failed {
-        one_day: 2
-      }
-      presubmit_runs_failed {
-        one_day: 1
-        seven_day: 1
-      }
-    }
-    # TODO(beining): WIP. This is going to replace threshold.
     # Clusters which fail to meet this threshold will be closed.
     thresholds {
       metric_id: "test-runs-failed"