From 9cba2e4802de50a396809bdb13eae54a8a82c499 Mon Sep 17 00:00:00 2001 From: "kjellander@webrtc.org" Date: Mon, 10 Feb 2014 12:43:40 +0000 Subject: [PATCH] Exclude libjingle_p2p_unittest tests failing TSan Race verifier. These tests have been failing for a long time at http://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20TsanRV This bot runs a tool called TSan Race Verifier. More info about Race Verifiers can be found at https://code.google.com/p/data-race-test/wiki/RaceVerifier By excluding the tests like this, they will also be disabled for the normal TSan bot, where they currently pass. This shouldn't be a problem since we have a TSan v2 bot running too (which uses a different set of suppressions), so it should catch any newly introduced race conditions. The TSan v2 bot will soon replace the old TSan bot, as v1 is being deprecated. TBR=mallinath@webrtc.org BUG=2396 TEST=Passing run on Linux of: GYP_DEFINES=build_with_tool=tsan gclient runhooks ninja -C out/Release libjingle_p2p_unittest tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan_rv -b out/Release -t libjingle_p2p_unittest Review URL: https://webrtc-codereview.appspot.com/8329005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@5515 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../libjingle_p2p_unittest.gtest-tsan_linux.txt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan_linux.txt b/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan_linux.txt index 92dcbf3c56..1e4f116caf 100644 --- a/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan_linux.txt +++ b/tools/valgrind-webrtc/gtest_exclude/libjingle_p2p_unittest.gtest-tsan_linux.txt @@ -1,3 +1,7 @@ # https://code.google.com/p/webrtc/issues/detail?id=2396 -P2PTransportChannelSameNatTest.TestConesBehindSameCone - +ChannelManagerTest.StartupShutdownOnThread +PortTest.* +P2PTransportChannel* +DtlsTransportChannelTest.* +RelayPortTest.* +PortAllocatorTest.*