diff --git a/rtc_base/numerics/histogram_percentile_counter.cc b/rtc_base/numerics/histogram_percentile_counter.cc index 10320002ee..87ebd53d47 100644 --- a/rtc_base/numerics/histogram_percentile_counter.cc +++ b/rtc_base/numerics/histogram_percentile_counter.cc @@ -53,7 +53,7 @@ rtc::Optional HistogramPercentileCounter::GetPercentile( RTC_CHECK_LE(fraction, 1.0); RTC_CHECK_GE(fraction, 0.0); if (total_elements_ == 0) - return rtc::Optional(); + return rtc::nullopt; size_t elements_to_skip = static_cast( std::max(0.0f, std::ceil(total_elements_ * fraction) - 1)); if (elements_to_skip >= total_elements_) @@ -61,19 +61,19 @@ rtc::Optional HistogramPercentileCounter::GetPercentile( if (elements_to_skip < total_elements_low_) { for (uint32_t value = 0; value < long_tail_boundary_; ++value) { if (elements_to_skip < histogram_low_[value]) - return rtc::Optional(value); + return value; elements_to_skip -= histogram_low_[value]; } } else { elements_to_skip -= total_elements_low_; for (const auto& it : histogram_high_) { if (elements_to_skip < it.second) - return rtc::Optional(it.first); + return it.first; elements_to_skip -= it.second; } } RTC_NOTREACHED(); - return rtc::Optional(); + return rtc::nullopt; } } // namespace rtc diff --git a/rtc_base/numerics/moving_max_counter_unittest.cc b/rtc_base/numerics/moving_max_counter_unittest.cc index a87533f668..4e74d6d4d2 100644 --- a/rtc_base/numerics/moving_max_counter_unittest.cc +++ b/rtc_base/numerics/moving_max_counter_unittest.cc @@ -14,15 +14,15 @@ TEST(MovingMaxCounter, ReportsMaximumInTheWindow) { rtc::MovingMaxCounter counter(100); counter.Add(1, 1); - EXPECT_EQ(counter.Max(1), rtc::Optional(1)); + EXPECT_EQ(counter.Max(1), 1); counter.Add(2, 30); - EXPECT_EQ(counter.Max(30), rtc::Optional(2)); + EXPECT_EQ(counter.Max(30), 2); counter.Add(100, 60); - EXPECT_EQ(counter.Max(60), rtc::Optional(100)); + EXPECT_EQ(counter.Max(60), 100); counter.Add(4, 70); - EXPECT_EQ(counter.Max(70), rtc::Optional(100)); + EXPECT_EQ(counter.Max(70), 100); counter.Add(5, 90); - EXPECT_EQ(counter.Max(90), rtc::Optional(100)); + EXPECT_EQ(counter.Max(90), 100); } TEST(MovingMaxCounter, IgnoresOldElements) { @@ -32,9 +32,9 @@ TEST(MovingMaxCounter, IgnoresOldElements) { counter.Add(100, 60); counter.Add(4, 70); counter.Add(5, 90); - EXPECT_EQ(counter.Max(160), rtc::Optional(100)); + EXPECT_EQ(counter.Max(160), 100); // 100 is now out of the window. Next maximum is 5. - EXPECT_EQ(counter.Max(161), rtc::Optional(5)); + EXPECT_EQ(counter.Max(161), 5); } TEST(MovingMaxCounter, HandlesEmptyWindow) { @@ -47,11 +47,11 @@ TEST(MovingMaxCounter, HandlesEmptyWindow) { TEST(MovingMaxCounter, HandlesSamplesWithEqualTimestamps) { rtc::MovingMaxCounter counter(100); counter.Add(2, 30); - EXPECT_EQ(counter.Max(30), rtc::Optional(2)); + EXPECT_EQ(counter.Max(30), 2); counter.Add(5, 30); - EXPECT_EQ(counter.Max(30), rtc::Optional(5)); + EXPECT_EQ(counter.Max(30), 5); counter.Add(4, 30); - EXPECT_EQ(counter.Max(30), rtc::Optional(5)); + EXPECT_EQ(counter.Max(30), 5); counter.Add(1, 90); - EXPECT_EQ(counter.Max(150), rtc::Optional(1)); + EXPECT_EQ(counter.Max(150), 1); } diff --git a/rtc_base/string_to_number.cc b/rtc_base/string_to_number.cc index 10df79ebfd..ad49d646d6 100644 --- a/rtc_base/string_to_number.cc +++ b/rtc_base/string_to_number.cc @@ -23,10 +23,10 @@ rtc::Optional ParseSigned(const char* str, int base) { errno = 0; const signed_type value = std::strtoll(str, &end, base); if (end && *end == '\0' && errno == 0) { - return rtc::Optional(value); + return value; } } - return rtc::Optional(); + return rtc::nullopt; } rtc::Optional ParseUnsigned(const char* str, int base) { @@ -40,10 +40,10 @@ rtc::Optional ParseUnsigned(const char* str, int base) { errno = 0; const unsigned_type value = std::strtoull(str, &end, base); if (end && *end == '\0' && errno == 0 && (value == 0 || !is_negative)) { - return rtc::Optional(value); + return value; } } - return rtc::Optional(); + return rtc::nullopt; } } // namespace string_to_number_internal diff --git a/rtc_base/string_to_number.h b/rtc_base/string_to_number.h index 2cdc4b8440..4a8fb8f8e1 100644 --- a/rtc_base/string_to_number.h +++ b/rtc_base/string_to_number.h @@ -65,9 +65,9 @@ StringToNumber(const char* str, int base = 10) { string_to_number_internal::ParseSigned(str, base); if (value && *value >= std::numeric_limits::lowest() && *value <= std::numeric_limits::max()) { - return rtc::Optional(static_cast(*value)); + return static_cast(*value); } - return rtc::Optional(); + return rtc::nullopt; } template @@ -83,9 +83,9 @@ StringToNumber(const char* str, int base = 10) { rtc::Optional value = string_to_number_internal::ParseUnsigned(str, base); if (value && *value <= std::numeric_limits::max()) { - return rtc::Optional(static_cast(*value)); + return static_cast(*value); } - return rtc::Optional(); + return rtc::nullopt; } // The std::string overloads only exists if there is a matching const char* diff --git a/rtc_base/string_to_number_unittest.cc b/rtc_base/string_to_number_unittest.cc index 5a6a23709f..f5e5b573f1 100644 --- a/rtc_base/string_to_number_unittest.cc +++ b/rtc_base/string_to_number_unittest.cc @@ -67,10 +67,10 @@ TYPED_TEST_P(BasicNumberTest, TestInvalidNumbers) { (min_value == 0) ? "-2" : (std::to_string(min_value) + "1"); // Make the large value approximately ten times larger than the maximum. const std::string too_large_string = std::to_string(max_value) + "1"; - EXPECT_EQ(rtc::Optional(), StringToNumber(too_low_string)); - EXPECT_EQ(rtc::Optional(), StringToNumber(too_low_string.c_str())); - EXPECT_EQ(rtc::Optional(), StringToNumber(too_large_string)); - EXPECT_EQ(rtc::Optional(), StringToNumber(too_large_string.c_str())); + EXPECT_EQ(rtc::nullopt, StringToNumber(too_low_string)); + EXPECT_EQ(rtc::nullopt, StringToNumber(too_low_string.c_str())); + EXPECT_EQ(rtc::nullopt, StringToNumber(too_large_string)); + EXPECT_EQ(rtc::nullopt, StringToNumber(too_large_string.c_str())); } TYPED_TEST_P(BasicNumberTest, TestInvalidInputs) { @@ -78,20 +78,18 @@ TYPED_TEST_P(BasicNumberTest, TestInvalidInputs) { const char kInvalidCharArray[] = "Invalid string containing 47"; const char kPlusMinusCharArray[] = "+-100"; const char kNumberFollowedByCruft[] = "640x480"; - EXPECT_EQ(rtc::Optional(), StringToNumber(kInvalidCharArray)); - EXPECT_EQ(rtc::Optional(), - StringToNumber(std::string(kInvalidCharArray))); - EXPECT_EQ(rtc::Optional(), StringToNumber(kPlusMinusCharArray)); - EXPECT_EQ(rtc::Optional(), - StringToNumber(std::string(kPlusMinusCharArray))); - EXPECT_EQ(rtc::Optional(), StringToNumber(kNumberFollowedByCruft)); - EXPECT_EQ(rtc::Optional(), + EXPECT_EQ(rtc::nullopt, StringToNumber(kInvalidCharArray)); + EXPECT_EQ(rtc::nullopt, StringToNumber(std::string(kInvalidCharArray))); + EXPECT_EQ(rtc::nullopt, StringToNumber(kPlusMinusCharArray)); + EXPECT_EQ(rtc::nullopt, StringToNumber(std::string(kPlusMinusCharArray))); + EXPECT_EQ(rtc::nullopt, StringToNumber(kNumberFollowedByCruft)); + EXPECT_EQ(rtc::nullopt, StringToNumber(std::string(kNumberFollowedByCruft))); - EXPECT_EQ(rtc::Optional(), StringToNumber(" 5")); - EXPECT_EQ(rtc::Optional(), StringToNumber(" - 5")); - EXPECT_EQ(rtc::Optional(), StringToNumber("- 5")); - EXPECT_EQ(rtc::Optional(), StringToNumber(" -5")); - EXPECT_EQ(rtc::Optional(), StringToNumber("5 ")); + EXPECT_EQ(rtc::nullopt, StringToNumber(" 5")); + EXPECT_EQ(rtc::nullopt, StringToNumber(" - 5")); + EXPECT_EQ(rtc::nullopt, StringToNumber("- 5")); + EXPECT_EQ(rtc::nullopt, StringToNumber(" -5")); + EXPECT_EQ(rtc::nullopt, StringToNumber("5 ")); } REGISTER_TYPED_TEST_CASE_P(BasicNumberTest, @@ -106,10 +104,10 @@ INSTANTIATE_TYPED_TEST_CASE_P(StringToNumberTest_Integers, IntegerTypes); TEST(StringToNumberTest, TestSpecificValues) { - EXPECT_EQ(rtc::Optional(), StringToNumber("256")); - EXPECT_EQ(rtc::Optional(), StringToNumber("-256")); - EXPECT_EQ(rtc::Optional(), StringToNumber("256")); - EXPECT_EQ(rtc::Optional(), StringToNumber("-256")); + EXPECT_EQ(rtc::nullopt, StringToNumber("256")); + EXPECT_EQ(rtc::nullopt, StringToNumber("-256")); + EXPECT_EQ(rtc::nullopt, StringToNumber("256")); + EXPECT_EQ(rtc::nullopt, StringToNumber("-256")); } } // namespace rtc