From 9bb8f80c405fb07c6d32f85c246578cb87898a21 Mon Sep 17 00:00:00 2001 From: Jiawei Ou Date: Mon, 9 Jul 2018 17:21:09 -0700 Subject: [PATCH] Make the default severity level of RTCCallbackLogger match the comment on its header. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comment here said it is kRTCLoggingSeverityInfo https://cs.chromium.org/chromium/src/third_party/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCCallbackLogger.h?type=cs&q=RTCCallbacklogger&sq=package:chromium&g=0&l=23 Which is not true since objective c auto initailize all member to 0, the severity level will be verbose. Bug: webrtc:9509 Change-Id: I894e2d8df33bf12bdf041cdee9e6dd3adef7fb12 Reviewed-on: https://webrtc-review.googlesource.com/87800 Reviewed-by: Anders Carlsson Commit-Queue: Kári Helgason Cr-Commit-Position: refs/heads/master@{#23898} --- sdk/objc/Framework/Classes/Common/RTCCallbackLogger.mm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sdk/objc/Framework/Classes/Common/RTCCallbackLogger.mm b/sdk/objc/Framework/Classes/Common/RTCCallbackLogger.mm index 0bfff73635..4802c12b74 100644 --- a/sdk/objc/Framework/Classes/Common/RTCCallbackLogger.mm +++ b/sdk/objc/Framework/Classes/Common/RTCCallbackLogger.mm @@ -41,6 +41,14 @@ class CallbackLogSink : public rtc::LogSink { @synthesize severity = _severity; +- (instancetype)init { + self = [super init]; + if (self != nil) { + _severity = RTCLoggingSeverityInfo; + } + return self; +} + - (void)dealloc { [self stop]; }