admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Temporarily removed the analog gain change detection in AEC3

Browse Source 
Due to the implementation of the analog AGC in the audio
processing module, the detection for the analog gain done in AEC3
fails on some platforms where there is no analog gain to control.

This CL removes that functionality until the AGC behavior has
been corrected.


Bug: webrtc:7910, chromium:738322
Change-Id: Ibdbe1e02252387dfd94b36ba7471f5c56ae27f48
Reviewed-on: https://chromium-review.googlesource.com/556040
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18850}
This commit is contained in:
Per Åhgren 2017-06-29 20:23:27 +02:00 committed by Commit Bot
parent 8f9ce1d991
commit 9aed31c24e
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
webrtc/modules/audio_processing/audio_processing_impl.cc
View File

@ -1229,10 +1229,9 @@ int AudioProcessingImpl::ProcessCaptureStreamLocked() {
}
if (private_submodules_->echo_canceller3) {
const int new_agc_level = gain_control()->stream_analog_level();
capture_.echo_path_gain_change =
abs(capture_.previous_agc_level - new_agc_level) > 5;
capture_.previous_agc_level = new_agc_level;
// TODO(peah): Reactivate analogue AGC gain detection once the analogue AGC
// issues have been addressed.
capture_.echo_path_gain_change = false;
private_submodules_->echo_canceller3->AnalyzeCapture(capture_buffer);
}
@ -2257,7 +2256,6 @@ AudioProcessingImpl::ApmCaptureState::ApmCaptureState(
target_direction(target_direction),
capture_processing_format(kSampleRate16kHz),
split_rate(kSampleRate16kHz),
previous_agc_level(0),
echo_path_gain_change(false) {}
AudioProcessingImpl::ApmCaptureState::~ApmCaptureState() = default;

1
webrtc/modules/audio_processing/audio_processing_impl.h
View File

@ -409,7 +409,6 @@ class AudioProcessingImpl : public AudioProcessing {
// tracked by the capture_audio_.
StreamConfig capture_processing_format;
int split_rate;
int previous_agc_level;
bool echo_path_gain_change;
} capture_ GUARDED_BY(crit_capture_);