admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup of voice_engine includes.

Browse Source 
I added a few missing dependencies to the GN target of voice_engine while doing other
unrelated work. Currently GN's header include checker has the
following to say:

  $ gn check out/gn_debug webrtc/voice_engine
  ERROR at //webrtc/voice_engine/include/voe_network.h:38:11: Include not allowed.
  #include "webrtc/transport.h"
            ^-----------------
  It is not in any dependency of
    //webrtc/voice_engine:voice_engine
  The include file is in the target(s):
    //webrtc:webrtc
  which should somehow be reachable.

transport.h should probably move in to webrtc/api, since it is already
a pure virtual interface and is used in quite a few places.

BUG=webrtc:5589
NOTRY=True

Review-Url: https://codereview.webrtc.org/2421483002
Cr-Commit-Position: refs/heads/master@{#14633}
This commit is contained in:
aleloi 2016-10-13 06:57:16 -07:00 committed by Commit bot
parent 3283cf917b
commit 9ae585de8d
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
webrtc/voice_engine/BUILD.gn
View File

@ -92,6 +92,9 @@ rtc_static_library("voice_engine") {
"../base:rtc_base_approved",
"../common_audio",
"../logging:rtc_event_log_api",
"../modules/audio_coding:audio_decoder_factory_interface",
"../modules/audio_coding:builtin_audio_decoder_factory",
"../modules/audio_coding:rent_a_codec",
"../modules/audio_conference_mixer",
"../modules/audio_device",
"../modules/audio_processing",

3
webrtc/voice_engine/voice_engine.gyp
View File

@ -21,11 +21,14 @@
'<(webrtc_root)/common_audio/common_audio.gyp:common_audio',
'<(webrtc_root)/modules/modules.gyp:audio_coding_module',
'<(webrtc_root)/modules/modules.gyp:audio_conference_mixer',
'<(webrtc_root)/modules/modules.gyp:audio_decoder_factory_interface',
'<(webrtc_root)/modules/modules.gyp:audio_device',
'<(webrtc_root)/modules/modules.gyp:audio_processing',
'<(webrtc_root)/modules/modules.gyp:bitrate_controller',
'<(webrtc_root)/modules/modules.gyp:builtin_audio_decoder_factory',
'<(webrtc_root)/modules/modules.gyp:media_file',
'<(webrtc_root)/modules/modules.gyp:paced_sender',
'<(webrtc_root)/modules/modules.gyp:rent_a_codec',
'<(webrtc_root)/modules/modules.gyp:rtp_rtcp',
'<(webrtc_root)/modules/modules.gyp:webrtc_utility',
'<(webrtc_root)/system_wrappers/system_wrappers.gyp:system_wrappers',