admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce audiosendstream dependency on rttstats (dead code).

Browse Source 
Change-Id: I4b05321548b6584424f23c45b0e95b4c03fe67c1
Bug: none
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148529
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31139}
This commit is contained in:
Tommi 2020-04-27 12:01:11 +02:00 committed by Commit Bot
parent b37e59d198
commit 9abc6bd8aa
3 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
audio/audio_send_stream.cc
View File

@ -114,7 +114,6 @@ AudioSendStream::AudioSendStream(
rtp_transport,
bitrate_allocator,
event_log,
rtcp_rtt_stats,
suspended_rtp_state,
voe::CreateChannelSend(clock,
task_queue_factory,
@ -138,7 +137,6 @@ AudioSendStream::AudioSendStream(
RtpTransportControllerSendInterface* rtp_transport,
BitrateAllocatorInterface* bitrate_allocator,
RtcEventLog* event_log,
RtcpRttStats* rtcp_rtt_stats,
const absl::optional<RtpState>& suspended_rtp_state,
std::unique_ptr<voe::ChannelSendInterface> channel_send)
: clock_(clock),

1
audio/audio_send_stream.h
View File

@ -73,7 +73,6 @@ class AudioSendStream final : public webrtc::AudioSendStream,
RtpTransportControllerSendInterface* rtp_transport,
BitrateAllocatorInterface* bitrate_allocator,
RtcEventLog* event_log,
RtcpRttStats* rtcp_rtt_stats,
const absl::optional<RtpState>& suspended_rtp_state,
std::unique_ptr<voe::ChannelSendInterface> channel_send);
~AudioSendStream() override;

4
audio/audio_send_stream_unittest.cc
View File

@ -29,7 +29,6 @@
#include "modules/audio_processing/include/audio_processing_statistics.h"
#include "modules/audio_processing/include/mock_audio_processing.h"
#include "modules/rtp_rtcp/mocks/mock_rtcp_bandwidth_observer.h"
#include "modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.h"
#include "modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
#include "rtc_base/task_queue_for_test.h"
#include "system_wrappers/include/clock.h"
@ -192,7 +191,7 @@ struct ConfigHelper {
new internal::AudioSendStream(
Clock::GetRealTimeClock(), stream_config_, audio_state_,
task_queue_factory_.get(), &rtp_transport_, &bitrate_allocator_,
&event_log_, &rtcp_rtt_stats_, absl::nullopt,
&event_log_, absl::nullopt,
std::unique_ptr<voe::ChannelSendInterface>(channel_send_)));
}
@ -331,7 +330,6 @@ struct ConfigHelper {
::testing::NiceMock<MockRtcEventLog> event_log_;
::testing::NiceMock<MockRtpTransportControllerSend> rtp_transport_;
::testing::NiceMock<MockRtpRtcp> rtp_rtcp_;
MockRtcpRttStats rtcp_rtt_stats_;
::testing::NiceMock<MockLimitObserver> limit_observer_;
BitrateAllocator bitrate_allocator_;
// |worker_queue| is defined last to ensure all pending tasks are cancelled