From 9aa7d8df95535aa681a637ffe56ffc7c7757868b Mon Sep 17 00:00:00 2001 From: "wu@webrtc.org" Date: Thu, 29 May 2014 05:03:52 +0000 Subject: [PATCH] Increase the threshold for CallPerfTest.CaptureNtpTimeWithNetworkDelay to avoid flaky. BUG=3374 R=stefan@webrtc.org Review URL: https://webrtc-codereview.appspot.com/19529004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6267 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/video/call_perf_tests.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/webrtc/video/call_perf_tests.cc b/webrtc/video/call_perf_tests.cc index 227528a451..bc0a1e011b 100644 --- a/webrtc/video/call_perf_tests.cc +++ b/webrtc/video/call_perf_tests.cc @@ -516,14 +516,12 @@ void CallPerfTest::TestCaptureNtpTime(const FakeNetworkPipe::Config& net_config, receiver_call->DestroyVideoReceiveStream(receive_stream); } -// Disabled due to being flaky, see issue 3374: -// https://code.google.com/p/webrtc/issues/detail?id=3374 -TEST_F(CallPerfTest, DISABLED_CaptureNtpTimeWithNetworkDelay) { +TEST_F(CallPerfTest, CaptureNtpTimeWithNetworkDelay) { FakeNetworkPipe::Config net_config; net_config.queue_delay_ms = 100; // TODO(wu): lower the threshold as the calculation/estimatation becomes more // accurate. - const int kThresholdMs = 30; + const int kThresholdMs = 100; const int kStartTimeMs = 10000; const int kRunTimeMs = 20000; TestCaptureNtpTime(net_config, kThresholdMs, kStartTimeMs, kRunTimeMs);