admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove HasSctpDataChannels() and just use HasDataChannels()

Browse Source 
Bug: none
Change-Id: I372cd386ad8ec057237889860802865836baaa0c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/298821
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39650}
This commit is contained in:
Tommi 2023-03-22 20:25:05 +01:00 committed by WebRTC LUCI CQ
parent 4bfc4ac4b0
commit 9a2938b24c
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pc/data_channel_controller.h
View File

@ -91,10 +91,6 @@ class DataChannelController : public SctpDataChannelControllerInterface,
bool HasDataChannels() const;
// At some point in time, a data channel has existed.
bool HasUsedDataChannels() const;
bool HasSctpDataChannels() const {
RTC_DCHECK_RUN_ON(signaling_thread());
return !sctp_data_channels_.empty();
}
// Accessors
DataChannelTransportInterface* data_channel_transport() const;

2
pc/sdp_offer_answer.cc
View File

@ -3265,7 +3265,7 @@ bool SdpOfferAnswerHandler::CheckIfNegotiationIsNeeded() {
// 4. If connection has created any RTCDataChannels, and no m= section in
// description has been negotiated yet for data, return true.
if (data_channel_controller()->HasSctpDataChannels()) {
if (data_channel_controller()->HasDataChannels()) {
if (!cricket::GetFirstDataContent(description->description()->contents()))
return true;
}