admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iOS AppRTCMobile: Fix SocketRocket bug

Browse Source 
Fixes a bug where a missing boolean-not causes AppRTCMobile to
always crash on an assert when built for Debug.

BUG=None
NOTRY=True
TBR=magjed@webrtc.org

Review-Url: https://codereview.webrtc.org/2721583002
Cr-Commit-Position: refs/heads/master@{#16865}
This commit is contained in:
kthelgason 2017-02-27 05:20:18 -08:00 committed by Commit bot
parent b3ebc1aa59
commit 99ce6cdf23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/examples/objc/AppRTCMobile/third_party/SocketRocket/SRWebSocket.m vendored
View File

@ -504,7 +504,7 @@ static __strong NSData *CRLFCRLF;
CFHTTPMessageSetHeaderFieldValue(request, CFSTR("Host"), (__bridge CFStringRef)(_url.port ? [NSString stringWithFormat:@"%@:%@", _url.host, _url.port] : _url.host));
NSMutableData *keyBytes = [[NSMutableData alloc] initWithLength:16];
BOOL success = SecRandomCopyBytes(kSecRandomDefault, keyBytes.length, keyBytes.mutableBytes);
BOOL success = !SecRandomCopyBytes(kSecRandomDefault, keyBytes.length, keyBytes.mutableBytes);
assert(success);
if ([keyBytes respondsToSelector:@selector(base64EncodedStringWithOptions:)]) {
@ -1362,7 +1362,7 @@ static const size_t SRFrameHeaderOverhead = 32;
}
} else {
uint8_t *mask_key = frame_buffer + frame_buffer_size;
BOOL success = SecRandomCopyBytes(kSecRandomDefault, sizeof(uint32_t), (uint8_t *)mask_key);
BOOL success = !SecRandomCopyBytes(kSecRandomDefault, sizeof(uint32_t), (uint8_t *)mask_key);
assert(success);
frame_buffer_size += sizeof(uint32_t);