admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

VideoEncoderFactoryTemplate cleanup.

Browse Source 
Bug: webrtc:13573
Change-Id: Id70e64adba6c5d76132dc0edb0c93937e3e894f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268542
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37524}
This commit is contained in:
philipel 2022-07-14 16:52:32 +02:00 committed by WebRTC LUCI CQ
parent f0232f31fb
commit 98c78cdd20
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
api/video_codecs/video_encoder_factory_template.h
View File

@ -46,9 +46,7 @@ template <typename... Ts>
class VideoEncoderFactoryTemplate : public VideoEncoderFactory {
public:
std::vector<SdpVideoFormat> GetSupportedFormats() const override {
std::vector<SdpVideoFormat> formats;
GetSupportedFormatsInternal<Ts...>(formats);
return formats;
return GetSupportedFormatsInternal<Ts...>();
}
std::unique_ptr<VideoEncoder> CreateVideoEncoder(
@ -86,17 +84,20 @@ class VideoEncoderFactoryTemplate : public VideoEncoderFactory {
}
template <typename V, typename... Vs>
void GetSupportedFormatsInternal(std::vector<SdpVideoFormat>& formats) const {
std::vector<SdpVideoFormat> GetSupportedFormatsInternal() const {
auto supported_formats = V::SupportedFormats();
for (const auto& format : supported_formats) {
if (!IsFormatInList(format, formats)) {
formats.push_back(format);
if constexpr (sizeof...(Vs) > 0) {
// Supported formats may overlap between implementations, so duplicates
// should be filtered out.
for (const auto& other_format : GetSupportedFormatsInternal<Vs...>()) {
if (!IsFormatInList(other_format, supported_formats)) {
supported_formats.push_back(other_format);
}
}
}
if constexpr (sizeof...(Vs) > 0) {
return GetSupportedFormatsInternal<Vs...>(formats);
}
return supported_formats;
}
template <typename V, typename... Vs>