admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add support for field trials to event log visualizer.

Browse Source 
BUG=None

Review-Url: https://codereview.webrtc.org/2499283002
Cr-Commit-Position: refs/heads/master@{#15086}
This commit is contained in:
stefan 2016-11-15 06:54:09 -08:00 committed by Commit bot
parent 614d5b78d6
commit 985d280b46
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
webrtc/tools/BUILD.gn
View File

@ -208,6 +208,7 @@ if (rtc_include_tests) {
defines = [ "ENABLE_RTC_EVENT_LOG" ] defines = [ "ENABLE_RTC_EVENT_LOG" ]
deps = [ deps = [
":event_log_visualizer_utils", ":event_log_visualizer_utils",
"../test:field_trial",
"//third_party/gflags", "//third_party/gflags",
] ]
} }

2
webrtc/tools/event_log_visualizer/analyzer.cc
View File

@ -1157,7 +1157,7 @@ void EventLogAnalyzer::CreateNetworkDelayFeedbackGraph(Plot* plot) {
if (rtp.header.extension.hasTransportSequenceNumber) { if (rtp.header.extension.hasTransportSequenceNumber) {
RTC_DCHECK(rtp.header.extension.hasTransportSequenceNumber); RTC_DCHECK(rtp.header.extension.hasTransportSequenceNumber);
feedback_adapter.AddPacket(rtp.header.extension.transportSequenceNumber, feedback_adapter.AddPacket(rtp.header.extension.transportSequenceNumber,
rtp.total_length, 0); rtp.total_length, PacketInfo::kNotAProbe);
feedback_adapter.OnSentPacket( feedback_adapter.OnSentPacket(
rtp.header.extension.transportSequenceNumber, rtp.timestamp / 1000); rtp.header.extension.transportSequenceNumber, rtp.timestamp / 1000);
} }

10
webrtc/tools/event_log_visualizer/main.cc
View File

@ -12,6 +12,7 @@
#include "gflags/gflags.h" #include "gflags/gflags.h"
#include "webrtc/logging/rtc_event_log/rtc_event_log_parser.h" #include "webrtc/logging/rtc_event_log/rtc_event_log_parser.h"
#include "webrtc/test/field_trial.h"
#include "webrtc/tools/event_log_visualizer/analyzer.h" #include "webrtc/tools/event_log_visualizer/analyzer.h"
#include "webrtc/tools/event_log_visualizer/plot_base.h" #include "webrtc/tools/event_log_visualizer/plot_base.h"
#include "webrtc/tools/event_log_visualizer/plot_python.h" #include "webrtc/tools/event_log_visualizer/plot_python.h"
@ -58,6 +59,13 @@ DEFINE_bool(plot_fraction_loss,
false, false,
"Plot packet loss in percent for outgoing packets (as perceived by " "Plot packet loss in percent for outgoing packets (as perceived by "
"the send-side bandwidth estimator)."); "the send-side bandwidth estimator).");
DEFINE_string(
force_fieldtrials,
"",
"Field trials control experimental feature code which can be forced. "
"E.g. running with --force_fieldtrials=WebRTC-FooFeature/Enabled/"
" will assign the group Enabled to field trial WebRTC-FooFeature. Multiple "
"trials are separated by \"/\"");
int main(int argc, char* argv[]) { int main(int argc, char* argv[]) {
std::string program_name = argv[0]; std::string program_name = argv[0];
@ -75,6 +83,8 @@ int main(int argc, char* argv[]) {
return 0; return 0;
} }
webrtc::test::InitFieldTrialsFromString(FLAGS_force_fieldtrials);
std::string filename = argv[1]; std::string filename = argv[1];
webrtc::ParsedRtcEventLog parsed_log; webrtc::ParsedRtcEventLog parsed_log;