admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Disabled TestPacketBuffer.SeqNumWrapOneFrame test due to clang update"

Browse Source 
This reverts commit 03c592a1e9f9dbad02bfc9d1f55d8b8c5c499208.

Reason for revert: Problem with clang should be solved now

Original change's description:
> Disabled TestPacketBuffer.SeqNumWrapOneFrame test due to clang update
> 
> Until further investigation.
> Clang update: chromium:880827
> 
> Bug: chromium:887464
> Change-Id: Id1fe85a013920e6ae8c6ac69efb0a0502b9dd6fe
> Reviewed-on: https://webrtc-review.googlesource.com/101561
> Commit-Queue: Artem Titarenko <artit@webrtc.org>
> Reviewed-by: Artem Titarenko <artit@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24795}

TBR=phoglund@webrtc.org,artit@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:887464
Change-Id: Id4d1722b289d9f56ae2aebf576f28f3b02a4c942
Reviewed-on: https://webrtc-review.googlesource.com/c/108583
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25428}
This commit is contained in:
Artem Titarenko 2018-10-30 10:17:54 +00:00 committed by Commit Bot
parent 0eb7d3ff35
commit 97e35ce05d
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
modules/video_coding/video_packet_buffer_unittest.cc
View File

@ -120,14 +120,7 @@ TEST_F(TestPacketBuffer, InsertDuplicatePacket) {
EXPECT_TRUE(Insert(seq_num, kKeyFrame, kFirst, kLast));
}
#if defined(WEBRTC_ANDROID)
// Fails on android after clang update
// TODO(crbug.com/887464): Reenable this
#define MAYBE_SeqNumWrapOneFrame DISABLED_SeqNumWrapOneFrame
#else
#define MAYBE_SeqNumWrapOneFrame SeqNumWrapOneFrame
#endif
TEST_F(TestPacketBuffer, MAYBE_SeqNumWrapOneFrame) {
TEST_F(TestPacketBuffer, SeqNumWrapOneFrame) {
EXPECT_TRUE(Insert(0xFFFF, kKeyFrame, kFirst, kNotLast));
EXPECT_TRUE(Insert(0x0, kKeyFrame, kNotFirst, kLast));