From 97d1c34769573c59fd92d82e6a74f31cb922db6b Mon Sep 17 00:00:00 2001 From: Andreas Pehrson Date: Fri, 13 Jan 2023 14:23:27 +0100 Subject: [PATCH] Enable rotation tests marked as expected failures MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:8382 Change-Id: I70ba0cdbdc9bd1e3014a379deb9ae39795e60d1f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290899 Reviewed-by: Kári Helgason Commit-Queue: Kári Helgason Cr-Commit-Position: refs/heads/main@{#39247} --- sdk/objc/unittests/RTCCameraVideoCapturerTests.mm | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sdk/objc/unittests/RTCCameraVideoCapturerTests.mm b/sdk/objc/unittests/RTCCameraVideoCapturerTests.mm index 7919878260..6a117a3546 100644 --- a/sdk/objc/unittests/RTCCameraVideoCapturerTests.mm +++ b/sdk/objc/unittests/RTCCameraVideoCapturerTests.mm @@ -186,9 +186,6 @@ CMSampleBufferRef createTestSampleBufferRef() { [self.delegateMock verify]; } -#if 0 -// See crbug.com/1404878 - XCTExpectFailure and XCTSkip are considered failures - - (void)testDelegateCallbackWithValidBufferAndOrientationUpdate { #if TARGET_OS_IPHONE XCTExpectFailure(@"Setting orientation on UIDevice is not supported"); @@ -295,8 +292,6 @@ CMSampleBufferRef createTestSampleBufferRef() { withOrientation:UIDeviceOrientationLandscapeRight]; } -#endif - - (void)setExif:(CMSampleBufferRef)sampleBuffer { rtc::ScopedCFTypeRef exif(CFDictionaryCreateMutable( kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)); @@ -304,9 +299,6 @@ CMSampleBufferRef createTestSampleBufferRef() { CMSetAttachment(sampleBuffer, CFSTR("{Exif}"), exif.get(), kCMAttachmentMode_ShouldPropagate); } -#if 0 -// See crbug.com/1404878 - XCTExpectFailure and XCTSkip are considered failures - - (void)testRotationFrame { #if TARGET_OS_IPHONE // Mock the AVCaptureConnection as we will get the camera position from the connection's @@ -352,8 +344,6 @@ CMSampleBufferRef createTestSampleBufferRef() { #endif } -#endif - - (void)testImageExif { #if TARGET_OS_IPHONE CMSampleBufferRef sampleBuffer = createTestSampleBufferRef();