admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Temporarily add dummy trackId to unblock roll."

Browse Source 
This reverts commit 3df4178d5966f9e2c9cb3bd97f27d7e86314ddb4.

Reason for revert: This dummy variable is no longer needed to make
importer happy

Original change's description:
> Temporarily add dummy trackId to unblock roll.
>
> NOTRY=True
>
> Bug: webrtc:15198
> Change-Id: I3090b90c549da3f2368001f2049bbf1d66042af4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306400
> Reviewed-by: Markus Handell <handellm@webrtc.org>
> Commit-Queue: Henrik Boström <hbos@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40130}

Bug: webrtc:15198
Change-Id: Ib47471259de72771292887050d1576707a473eec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306401
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Markus Handell <handellm@webrtc.org>
Auto-Submit: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40135}
This commit is contained in:
Henrik Boström 2023-05-24 12:59:07 +00:00 committed by WebRTC LUCI CQ
parent aa1ad7d6a4
commit 979b0479a1
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
api/stats/rtcstats_objects.h
View File

@ -428,10 +428,6 @@ class RTC_EXPORT RTCInboundRtpStreamStats final
// The former googMinPlayoutDelayMs (in seconds).
RTCNonStandardStatsMember<double> min_playout_delay;
// Temporarily added to unblock a roll.
// TODO(https://crbug.com/webrtc/15198): Delete this.
RTCStatsMember<std::string> track_id;
};
// https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*
@ -483,10 +479,6 @@ class RTC_EXPORT RTCOutboundRtpStreamStats final
RTCRestrictedStatsMember<bool, StatExposureCriteria::kHardwareCapability>
power_efficient_encoder;
RTCStatsMember<std::string> scalability_mode;
// Temporarily added to unblock a roll.
// TODO(https://crbug.com/webrtc/15198): Delete this.
RTCStatsMember<std::string> track_id;
};
// https://w3c.github.io/webrtc-stats/#remoteinboundrtpstats-dict*

6
stats/rtcstats_objects.cc
View File

@ -486,8 +486,7 @@ RTCInboundRtpStreamStats::RTCInboundRtpStreamStats(std::string id,
relative_packet_arrival_delay("relativePacketArrivalDelay"),
interruption_count("interruptionCount"),
total_interruption_duration("totalInterruptionDuration"),
min_playout_delay("minPlayoutDelay"),
track_id("trackId") {}
min_playout_delay("minPlayoutDelay") {}
RTCInboundRtpStreamStats::RTCInboundRtpStreamStats(
const RTCInboundRtpStreamStats& other) = default;
@ -561,8 +560,7 @@ RTCOutboundRtpStreamStats::RTCOutboundRtpStreamStats(std::string id,
qp_sum("qpSum"),
active("active"),
power_efficient_encoder("powerEfficientEncoder"),
scalability_mode("scalabilityMode"),
track_id("trackId") {}
scalability_mode("scalabilityMode") {}
RTCOutboundRtpStreamStats::RTCOutboundRtpStreamStats(
const RTCOutboundRtpStreamStats& other) = default;