admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AEC3:Turning off default downmix in surround alignment

Browse Source 
This CL changes the downmixing of the input to the delay estimation
for surround/stereo signals to be off by default.

A kill-switch is also added for enforcing the downmix to be on.

Bug: webrtc:10913
Change-Id: I1030fef593ba56416deeb13b80d2f3812bffb9ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161012
Commit-Queue: Per Åhgren <peah@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29951}
This commit is contained in:
Per Åhgren 2019-11-28 17:19:27 +01:00 committed by Commit Bot
parent 253d50fbe6
commit 9750e84d7a
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/audio/echo_canceller3_config.h
View File

@ -47,7 +47,7 @@ struct RTC_EXPORT EchoCanceller3Config {
int converged;
} delay_selection_thresholds = {5, 20};
bool use_external_delay_estimator = false;
bool downmix_before_delay_estimation = true;
bool downmix_before_delay_estimation = false;
bool log_warning_on_delay_changes = false;
} delay;

4
modules/audio_processing/aec3/echo_canceller3.cc
View File

@ -51,6 +51,10 @@ EchoCanceller3Config AdjustConfig(const EchoCanceller3Config& config) {
adjusted_cfg.erle.clamp_quality_estimate_to_one = false;
}
if (field_trial::IsEnabled("WebRTC-Aec3AlignmentOnLeftChannelKillSwitch")) {
adjusted_cfg.delay.downmix_before_delay_estimation = true;
}
return adjusted_cfg;
}