From 970b911f765e79778ed4268396180f89808e9350 Mon Sep 17 00:00:00 2001 From: Hyesung Kim Date: Tue, 9 Apr 2024 15:46:31 +0900 Subject: [PATCH] Fixed warning log generation for IRAP frames in H265 Aggregation Packet. When an IRAP frame was present in the Aggregation Packet, the control flow was incorrectly transferred to SPS parsing due to ABSL_FALLTHROUGH_INTENDED within the IRAP case statement, resulting in a parsing error and generating a warning log. A break statement has been introduced to prevent this fallthrough. Bug: webrtc:13485 Change-Id: I523fbf548f14b31eae7c41f607fe33572f094aac Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/346381 Reviewed-by: Danil Chapovalov Reviewed-by: Daniel.L (Byoungchan) Lee Commit-Queue: Daniel.L (Byoungchan) Lee Cr-Commit-Position: refs/heads/main@{#42132} --- modules/rtp_rtcp/source/video_rtp_depacketizer_h265.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/rtp_rtcp/source/video_rtp_depacketizer_h265.cc b/modules/rtp_rtcp/source/video_rtp_depacketizer_h265.cc index cea55078e5..fdb5680a96 100644 --- a/modules/rtp_rtcp/source/video_rtp_depacketizer_h265.cc +++ b/modules/rtp_rtcp/source/video_rtp_depacketizer_h265.cc @@ -134,7 +134,7 @@ absl::optional ProcessApOrSingleNalu( // https://datatracker.ietf.org/doc/html/rfc7798#section-3.1.1 parsed_payload->video_header.frame_type = VideoFrameType::kVideoFrameKey; - ABSL_FALLTHROUGH_INTENDED; + break; case H265::NaluType::kSps: { // Copy any previous data first (likely just the first header). std::unique_ptr output_buffer(new rtc::Buffer());