admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add ARC enablement to WebRTC only if it isn't already present

Browse Source 
WebRTC unconditionally enables ARC for Objective-C code. Chromium is
now enabling this globally, so change WebRTC to only enable it if it's
not already enabled.

Bug: chromium:733237
Change-Id: I0d5694d0640bb79ae83209aa0bdd36e099b85042
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314180
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40493}
This commit is contained in:
Avi Drissman 2023-07-30 17:26:01 -04:00 committed by WebRTC LUCI CQ
parent 4b87d7ac2a
commit 96137813f7
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc.gni
View File

@ -356,7 +356,10 @@ webrtc_root = get_path_info(".", "abspath")
rtc_common_configs = [ webrtc_root + ":common_config" ] rtc_common_configs = [ webrtc_root + ":common_config" ]
if (is_mac || is_ios) { if (is_mac || is_ios) {
rtc_common_configs += [ "//build/config/compiler:enable_arc" ] if (filter_include(default_compiler_configs,
[ "//build/config/compiler:enable_arc" ]) == []) {
rtc_common_configs += [ "//build/config/compiler:enable_arc" ]
}
} }
# Global public configuration that should be applied to all WebRTC targets. You # Global public configuration that should be applied to all WebRTC targets. You